Skip to content

fix(ops): propagate scale-out restore environment - #10823

Merged
leon-ape merged 1 commit into
release-1.0from
bugfix/10815-restore-env-release-1.0
Aug 30, 2026
Merged

fix(ops): propagate scale-out restore environment#10823
leon-ape merged 1 commit into
release-1.0from
bugfix/10815-restore-env-release-1.0

Conversation

@leon-ape

Copy link
Copy Markdown
Collaborator

Fixes #10815.

Release 1.0 counterpart of #10817.

Problem

During horizontal scale-out from a Backup, scaleOut.fromBackup.restoreEnv is dropped before the generated Restore is created.

Changes

  • add an explicit RestoreManager setter for user-provided Restore environment
  • pass FromBackup.restoreEnv into the scale-out Restore plan
  • verify Restore.spec.env in focused plan and Operations coverage

Scope

This PR only propagates restore environment on release-1.0. It does not change Backup validation, namespaces, authorization, VolumeSnapshot behavior, or source-target selection.

Validation

  • scripts/codex-go-test.sh ./pkg/controller/plan -count=1
  • scripts/codex-go-test.sh ./pkg/operations -count=1
  • git diff --check

@leon-ape
leon-ape requested a review from a team as a code owner August 28, 2026 10:18
@leon-ape leon-ape added the nopick Not auto cherry-pick when PR merged label Aug 28, 2026
@apecloud-bot

Copy link
Copy Markdown
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

CLA Recheck Instructions

Usage:
  - /recheck-cla: Trigger a re-check of CLA status for this pull request.
Example:
  - /recheck-cla

@github-actions github-actions Bot added the size/M Denotes a PR that changes 30-99 lines. label Aug 28, 2026
@leon-ape leon-ape changed the title [release-1.0] fix(ops): propagate scale-out restore environment fix(ops): propagate scale-out restore environment [release-1.0] Aug 28, 2026
@leon-ape leon-ape changed the title fix(ops): propagate scale-out restore environment [release-1.0] chore(ops): backport scale-out restore environment [release-1.0] Aug 28, 2026
@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.31%. Comparing base (c55a6d5) to head (c069e2c).
⚠️ Report is 1 commits behind head on release-1.0.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.0   #10823      +/-   ##
===============================================
+ Coverage        54.17%   54.31%   +0.13%     
===============================================
  Files              495      495              
  Lines            55939    55948       +9     
===============================================
+ Hits             30305    30387      +82     
+ Misses           22624    22571      -53     
+ Partials          3010     2990      -20     
Flag Coverage Δ
unittests 54.31% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leon-ape leon-ape changed the title chore(ops): backport scale-out restore environment [release-1.0] fix(ops): propagate scale-out restore environment Aug 30, 2026
@leon-ape

Copy link
Copy Markdown
Collaborator Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Aug 30, 2026
@leon-ape leon-ape linked an issue Aug 30, 2026 that may be closed by this pull request
@leon-ape
leon-ape merged commit 46a44ab into release-1.0 Aug 30, 2026
51 of 54 checks passed
@leon-ape
leon-ape deleted the bugfix/10815-restore-env-release-1.0 branch August 30, 2026 05:14
@github-actions github-actions Bot added this to the Release 1.2.0 milestone Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test nopick Not auto cherry-pick when PR merged size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ops): propagate scale-out restore environment

2 participants