Skip to content

chore: support image replacement of parameters based on the serviceVersion - #10038

Merged
wangyelei merged 2 commits into
mainfrom
feature/pd_multi_service_version
Feb 3, 2026
Merged

chore: support image replacement of parameters based on the serviceVersion#10038
wangyelei merged 2 commits into
mainfrom
feature/pd_multi_service_version

Conversation

@wangyelei

Copy link
Copy Markdown
Contributor

No description provided.

@wangyelei
wangyelei requested a review from a team as a code owner February 3, 2026 06:07
@wangyelei wangyelei added pick-1.0 Auto cherry-pick to release-1.0 when PR merged pick-1.1 Auto cherry-pick to release-1.1 when PR merged labels Feb 3, 2026
@github-actions github-actions Bot added the size/L Denotes a PR that changes 100-499 lines. label Feb 3, 2026
@apecloud-bot

Copy link
Copy Markdown
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

@codecov

codecov Bot commented Feb 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.53%. Comparing base (804edc4) to head (b104ed1).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pkg/parameters/tool_image_builder.go 71.42% 1 Missing and 1 partial ⚠️
pkg/parameters/config_util.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10038      +/-   ##
==========================================
+ Coverage   51.37%   51.53%   +0.15%     
==========================================
  Files         541      544       +3     
  Lines       58774    59665     +891     
==========================================
+ Hits        30194    30746     +552     
- Misses      25627    25899     +272     
- Partials     2953     3020      +67     
Flag Coverage Δ
unittests 51.53% <62.50%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Feb 3, 2026
@shanshanying

shanshanying commented Feb 3, 2026

Copy link
Copy Markdown
Collaborator

@cjc7373 cjc7373 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think reload sidecar will soon be replaced by kbagent in 1.2?

@wangyelei
wangyelei merged commit 2a7e088 into main Feb 3, 2026
40 checks passed
@wangyelei
wangyelei deleted the feature/pd_multi_service_version branch February 3, 2026 07:19
@github-actions github-actions Bot added this to the Release 1.2.0 milestone Feb 3, 2026
@apecloud-bot

Copy link
Copy Markdown
Collaborator

/cherry-pick release-1.0

@apecloud-bot

Copy link
Copy Markdown
Collaborator

/cherry-pick release-1.1

@apecloud-bot

Copy link
Copy Markdown
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/21620907804

apecloud-bot pushed a commit that referenced this pull request Feb 3, 2026
@apecloud-bot

Copy link
Copy Markdown
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/21620908266

apecloud-bot pushed a commit that referenced this pull request Feb 3, 2026
@wangyelei

Copy link
Copy Markdown
Contributor Author

I think reload sidecar will soon be replaced by kbagent in 1.2?

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test pick-1.0 Auto cherry-pick to release-1.0 when PR merged pick-1.1 Auto cherry-pick to release-1.1 when PR merged size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants