remove staticcheck

it's covered by golangci-lint

Author: cjc7373

.github/workflows/cicd-pull-request.yml

@@ -80,7 +80,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        ops: [ 'manifests', 'mod-vendor', 'generate', 'lint', 'staticcheck', 'test' ]
+        ops: [ 'manifests', 'mod-vendor', 'generate', 'lint', 'test' ]
     steps:
       - uses: actions/checkout@v4
       - name: install lib

.github/workflows/cicd-push.yml

@@ -105,7 +105,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        ops: [ 'manifests', 'mod-vendor', 'generate', 'lint', 'staticcheck', 'test' ]
+        ops: [ 'manifests', 'mod-vendor', 'generate', 'lint', 'test' ]
     steps:
       - uses: actions/checkout@v4
       - name: install lib

.github/workflows/release-version.yml

@@ -28,7 +28,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        ops: [ 'manifests', 'mod-vendor', 'generate', 'lint', 'staticcheck', 'test' ]
+        ops: [ 'manifests', 'mod-vendor', 'generate', 'lint', 'test' ]
     steps:
       - uses: actions/checkout@v4
       - name: install lib

Makefile

@@ -145,7 +145,7 @@ vet: test-go-generate ## Run go vet against code.
 	GOOS=$(GOOS) $(GO) vet -mod=mod ./...
 
 .PHONY: lint-fast
-lint-fast: staticcheck vet golangci-lint # [INTERNAL] Run all lint job against code.
+lint-fast: vet golangci-lint # [INTERNAL] Run all lint job against code.
 
 .PHONY: lint
 lint: test-go-generate generate ## Run default lint job against code.
@@ -155,10 +155,6 @@ lint: test-go-generate generate ## Run default lint job against code.
 golangci-lint: golangci-lint-bin generate ## Run golangci-lint against code.
 	$(GOLANGCILINT) run ./...
 
-.PHONY: staticcheck
-staticcheck: staticcheck-bin test-go-generate generate ## Run staticcheck against code.
-	$(STATICCHECK) ./...
-
 .PHONY: build-checks
 build-checks: fmt vet goimports lint-fast ## Run build checks.
 
@@ -396,12 +392,6 @@ golangci-lint-bin: $(LOCALBIN) ## Download golangci-lint locally if necessary.
 		mv "$(LOCALBIN)/golangci-lint" "$(GOLANGCILINT)"; \
 	}
 
-STATICCHECK_VERSION = v0.6.1
-STATICCHECK = $(LOCALBIN)/staticcheck-$(STATICCHECK_VERSION)
-.PHONY: staticcheck-bin
-staticcheck-bin: $(LOCALBIN) ## Download staticcheck locally if necessary.
-	$(call go-install-tool,$(STATICCHECK),honnef.co/go/tools/cmd/staticcheck,$(STATICCHECK_VERSION))
-
 GOIMPORTS_VERSION = v0.34.0
 GOIMPORTS = $(LOCALBIN)/goimports-$(GOIMPORTS_VERSION)
 .PHONY: goimports-bin