linter fix

Author: cjc7373

.github/workflows/cicd-pull-request.yml

@@ -99,7 +99,7 @@ jobs:
       - name: Install golangci-lint
         if: matrix.ops == 'lint'
         run: |
-          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.64.5
+          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v2.8.0
 
       - name: make ${{ matrix.ops }}
         run: |

.github/workflows/cicd-push.yml

@@ -124,7 +124,7 @@ jobs:
       - name: Install golangci-lint
         if: matrix.ops == 'lint'
         run: |
-          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.64.5
+          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v2.8.0
 
       - name: make ${{ matrix.ops }}
         run: |

.github/workflows/release-version.yml

@@ -47,7 +47,7 @@ jobs:
       - name: Install golangci-lint
         if: matrix.ops == 'lint'
         run: |
-          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.64.5
+          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v2.8.0
 
       - name: make ${{ matrix.ops }}
         run: |

.golangci.yaml

@@ -28,6 +28,7 @@ linters:
         - '-ST1001' # Dot imports are discouraged
         - '-SA1019' # Using a deprecated function, variable, constant or field
         - '-QF1008' # Omit embedded fields from selector expression
+        - '-QF1001' # Apply De Morgan’s law
   exclusions:
     generated: lax
     presets:

Makefile

@@ -386,7 +386,7 @@ controller-gen: $(LOCALBIN) ## Download controller-gen locally if necessary.
 envtest: $(LOCALBIN) ## Download envtest-setup locally if necessary.
 	$(call go-install-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/setup-envtest,$(ENVTEST_VERSION))
 
-GOLANGCILINT_VERSION = v1.64.8
+GOLANGCILINT_VERSION = v2.8.0
 GOLANGCILINT = $(LOCALBIN)/golangci-lint-$(GOLANGCILINT_VERSION)
 .PHONY: golangci-lint-bin
 golangci-lint-bin: $(LOCALBIN) ## Download golangci-lint locally if necessary.

apis/apps/v1alpha1/type.go

@@ -109,6 +109,7 @@ type ConfigTemplateExtension struct {
 }
 
 // LegacyRenderedTemplateSpec describes the configuration extension for the lazy rendered template.
+//
 // Deprecated: LegacyRenderedTemplateSpec has been deprecated since 0.9.0 and will be removed in 0.10.0
 type LegacyRenderedTemplateSpec struct {
 	// Extends the configuration template.

apis/workloads/v1alpha1/instanceset_types.go

@@ -27,6 +27,7 @@ import (
 // NOTE: json tags are required.  Any new fields you add must have json tags for the fields to be serialized.
 
 // SchedulingPolicy the scheduling policy.
+//
 // Deprecated: Unify with apps/v1alpha1.SchedulingPolicy
 type SchedulingPolicy struct {
 	// If specified, the Pod will be dispatched by specified scheduler.

controllers/trace/reconciler_tree.go

@@ -653,9 +653,10 @@ func (r *jobReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.R
 		}
 		// Update job status based on pod completion
 		if err = r.Get(ctx, client.ObjectKeyFromObject(pod), pod); err == nil {
-			if pod.Status.Phase == corev1.PodSucceeded {
+			switch pod.Status.Phase {
+			case corev1.PodSucceeded:
 				job.Status.Succeeded++
-			} else if pod.Status.Phase == corev1.PodFailed {
+			case corev1.PodFailed:
 				job.Status.Failed++
 			}
 		}

docker/Dockerfile-dev

@@ -14,7 +14,7 @@ ARG INSTALL_ZSH="true"
 ARG KUBECTL_VERSION="latest"
 ARG HELM_VERSION="latest"
 ARG MINIKUBE_VERSION="latest"
-ARG GOLANGCI_LINT_VERSION="1.64.5"
+ARG GOLANGCI_LINT_VERSION="2.8.0"
 
 ARG USERNAME=kubeblocks
 ARG USER_UID=1000

docs/developer_docs/api-reference/cluster.md

@@ -25053,8 +25053,8 @@ It is required when the issuer is set to <code>UserProvided</code>.</p>
 (<em>Appears on:</em><a href="#apps.kubeblocks.io/v1alpha1.ComponentConfigSpec">ComponentConfigSpec</a>)
 </p>
 <div>
-<p>LegacyRenderedTemplateSpec describes the configuration extension for the lazy rendered template.
-Deprecated: LegacyRenderedTemplateSpec has been deprecated since 0.9.0 and will be removed in 0.10.0</p>
+<p>LegacyRenderedTemplateSpec describes the configuration extension for the lazy rendered template.</p>
+<p>Deprecated: LegacyRenderedTemplateSpec has been deprecated since 0.9.0 and will be removed in 0.10.0</p>
 </div>
 <table>
 <thead>
@@ -36399,8 +36399,8 @@ RoleUpdateMechanism
 (<em>Appears on:</em><a href="#workloads.kubeblocks.io/v1alpha1.InstanceTemplate">InstanceTemplate</a>)
 </p>
 <div>
-<p>SchedulingPolicy the scheduling policy.
-Deprecated: Unify with apps/v1alpha1.SchedulingPolicy</p>
+<p>SchedulingPolicy the scheduling policy.</p>
+<p>Deprecated: Unify with apps/v1alpha1.SchedulingPolicy</p>
 </div>
 <table>
 <thead>