fix(postgresql): preserve pgdump restore owners and privileges - #3440
Draft
weicao wants to merge 2 commits into
Draft
fix(postgresql): preserve pgdump restore owners and privileges#3440weicao wants to merge 2 commits into
weicao wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.1 #3440 +/- ##
===========================================
Coverage 0.00% 0.00%
===========================================
Files 80 81 +1
Lines 10053 10140 +87
===========================================
- Misses 10053 10140 +87 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design
skip_ownerandskip_privilegesboolean opt-outs, both defaulting tofalse.Exact identities
release-1.1ea888871004fe19cef503e1585014bc233dd44448fc8d2ae61d3bcb4c9bd4c64d15da30fdff2407d2b3c317e71bc5f7079c90f1f59fd14f2ce0544e1e395b24f2651eea686294988d812474407d57911release-1.0candidate: fix(postgresql): preserve pgdump restore owners and privileges #3441TDD evidence
8d58116b:skip_owner.default false -> trueandskip_privileges.type boolean -> stringeach falsely stayed 6/0.--severity=error), Bash 3.2/5.3bash -n,git diff --check: pass.default: false, and both names are present inrestore.withParameters.Runtime boundary
Runtime acceptance remains Fixed Test-owned and
UNKNOWNin this source PR. The authorized remote test must use a real archive and separately prove:skip_owner=truechanges only ownership restoration;skip_privileges=truechanges only ACL restoration;Local stubs are source-contract evidence only and are not a runtime substitute.