fix(mariadb): fail closed on unsafe Galera bootstrap#2997
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2997 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 140 140
Lines 22548 22597 +49
=====================================
- Misses 22548 22597 +49 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
leon-ape
left a comment
There was a problem hiding this comment.
With the new pod-0 fail-closed path, the existing non-pod-0 guard still ignores safe_to_bootstrap: 1. In a clean full shutdown where Galera marks a non-pod-0 as the safe node, pod-0 exits with the defer reason and that safe non-pod-0 also returns false to join, so no pod bootstraps the cluster.
601b0ad to
cdb834a
Compare
|
Addressed in Change made:
Local validation on the rebased commit:
|
cdb834a to
3a4ae56
Compare
|
Addressed fresh Galera bootstrap regression in Change made:
Local validation:
|
3a4ae56 to
4acd3fa
Compare
Summary
safe_to_bootstrap: 0tosafe_to_bootstrap: 1during full Galera crash recoverywsrep-recoverseqno as evidence onlyCloses #2996.
Validation
shellspec --load-path ./shellspec --shell bash addons/mariadb/scripts-ut-spec/galera_start_spec.sh-> 7 examples, 0 failuresbash -n addons/mariadb/scripts/galera-start.sh addons/mariadb/scripts-ut-spec/galera_start_spec.shgit diff --check -- addons/mariadb/scripts/galera-start.sh addons/mariadb/scripts-ut-spec/galera_start_spec.shEvidence boundary
This PR fixes the source-level unsafe bootstrap path and has focused unit coverage. It does not claim that the full Galera crash-recovery scenario is runtime-passed until the patched chart/image is validated in a live cluster.