SOLR-18093: Add top-level 'queries' support to JsonQueryRequest in SolrJ#4276
Open
ercsonusharma wants to merge 4 commits intoapache:mainfrom
Open
SOLR-18093: Add top-level 'queries' support to JsonQueryRequest in SolrJ#4276ercsonusharma wants to merge 4 commits intoapache:mainfrom
ercsonusharma wants to merge 4 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18093
Description
Currently,
JsonQueryRequestin SolrJ supports specifying a single query via setQuery() and other top-level parameters like limit, sort, fields etc.However, it does not support top-level "queries" blocks, which is a good addition to fully leverage the combined query component and the Additional Queries feature in Solr’s JSON Query DSL. This limitation prevents constructing multiple queries or additional scoring/re-ranking queries in a single JSON request from the client side.
Solution
Added method to pass the required params in
JsonQueryRequest. Also, enhanced the documentation.Tests
Added Unit tests and Integration tests.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.