SOLR-17318 VersionTool now reports remote server version#4275
Open
janhoy wants to merge 1 commit intoapache:mainfrom
Open
SOLR-17318 VersionTool now reports remote server version#4275janhoy wants to merge 1 commit intoapache:mainfrom
janhoy wants to merge 1 commit intoapache:mainfrom
Conversation
…ersion when `--solr-url` is provided
Contributor
Author
|
PS: picocli support will be added later in the picocli branch after rebasing... |
epugh
reviewed
Apr 9, 2026
Contributor
epugh
left a comment
epugh
left a comment
There was a problem hiding this comment.
Nice to get this jira knocked out!
| @Override | ||
| public Options getOptions() { | ||
| return super.getOptions() | ||
| .addOption(CommonCLIOptions.SOLR_URL_OPTION) |
Contributor
There was a problem hiding this comment.
Do we need to support the --zk option to connect for consistency? Don't all our tools allow both??
| tool.runTool(SolrCLI.processCommandLineArgs(tool, toolArgs)); | ||
|
|
||
| String output = runtime.getOutput(); | ||
| assertTrue("Output should contain 'Client version:'", output.contains("Client version:")); |
Contributor
There was a problem hiding this comment.
In other code I saw a nicer assert style for contains in a setting🤔, though I can't remember right now what it was!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...when
--solr-urlis providedhttps://issues.apache.org/jira/browse/SOLR-17318