Skip to content

Bump skywalking-ui submodule for SWIP-12 i18n menu labels#13840

Merged
wu-sheng merged 1 commit intomasterfrom
feature/swip12-ui-i18n-bump
Apr 21, 2026
Merged

Bump skywalking-ui submodule for SWIP-12 i18n menu labels#13840
wu-sheng merged 1 commit intomasterfrom
feature/swip12-ui-i18n-bump

Conversation

@wu-sheng
Copy link
Copy Markdown
Member

Bump the skywalking-ui submodule to pick up apache/skywalking-booster-ui#548, which adds mobile_wechat_mini_program / mobile_alipay_mini_program i18n keys (en / zh / es) for the two SWIP-12 sub-menus under Mobile. Before this bump, the menu labels rendered as the raw i18nKey string in the UI.

Also reconcile the SWIP-12 OAP Server changelog entry with what actually shipped — the earlier wording claimed componentId-driven layer mapping in CommonAnalysisListener, which was reverted during review (mini-programs are client-side / exit-only, same pattern as browser and iOS, so CommonAnalysisListener stays unchanged and service / instance / endpoint entities come from MAL + LAL). Added an entry for the TimeUnit enum registration in MALCodegenHelper.ENUM_FQCN that shipped alongside SWIP-12.

  • If this is non-trivial feature, paste the links/URLs to the design doc. — SWIP-12

  • Update the documentation to include this new feature. — changelog UI + OAP Server entries reconciled

  • Tests(including UT, IT, E2E) are added to verify the new feature. — no code change; submodule pointer + docs only

  • If it's UI related, attach the screenshots below.

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.

  • Update the `CHANGES` log.

apache/skywalking-booster-ui#548 landed on main (commit d39db06b34),
adding mobile_wechat_mini_program / mobile_alipay_mini_program i18n
keys (en / zh / es) for the two SWIP-12 sub-menus under Mobile.

Before: menu labels fell back to the raw i18nKey string.
After: menu labels read 'WeChat Mini Program' and 'Alipay Mini Program'.

Also reconcile the SWIP-12 OAP Server changelog entry with what
actually shipped — the earlier wording claimed componentId-driven layer
mapping in CommonAnalysisListener, which was reverted during review
(mini-programs are client-side / exit-only, same browser pattern, so
CommonAnalysisListener stays unchanged and service / instance / endpoint
entities come from MAL + LAL). Mention the MAL enhancement (TimeUnit in
ENUM_FQCN) that shipped alongside.
@wu-sheng wu-sheng requested a review from Copilot April 21, 2026 07:48
@wu-sheng wu-sheng added this to the 10.5.0 milestone Apr 21, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the 10.5.0 changelog to reflect the shipped SWIP-12 mini-program behavior and to note the UI i18n label fix for the new Mobile sub-menus.

Changes:

  • Reword the SWIP-12 OAP Server changelog entry to match the implemented architecture (MAL/LAL-driven entities; no RPCAnalysisListener change).
  • Add a changelog entry noting TimeUnit enum registration for MAL histogram unit selection.
  • Add a UI changelog entry noting i18n labels for WeChat/Alipay Mini Program menu items.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wu-sheng wu-sheng added the UI UI and front end related. label Apr 21, 2026
@wu-sheng wu-sheng merged commit 315defe into master Apr 21, 2026
21 checks passed
@wu-sheng wu-sheng deleted the feature/swip12-ui-i18n-bump branch April 21, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI UI and front end related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants