BanyanDB: fix query getInstance by instance ID.#13549
Merged
wu-sheng merged 2 commits intoapache:masterfrom Oct 21, 2025
Merged
BanyanDB: fix query getInstance by instance ID.#13549wu-sheng merged 2 commits intoapache:masterfrom
getInstance by instance ID.#13549wu-sheng merged 2 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the BanyanDB metadata query implementation where getInstance was incorrectly querying by service ID and instance name instead of directly using the instance ID.
Key changes:
- Modified the
getInstancemethod to query using the instance ID directly - Removed unnecessary ID analysis logic that was decomposing the instance ID
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
wu-sheng
approved these changes
Oct 21, 2025
hanahmily
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.