[Chore][CI] Re-enable dead-link check job#10733
Open
zhangshenghang wants to merge 18 commits intoapache:devfrom
Open
[Chore][CI] Re-enable dead-link check job#10733zhangshenghang wants to merge 18 commits intoapache:devfrom
zhangshenghang wants to merge 18 commits intoapache:devfrom
Conversation
Fix broken relative links in sink connector docs (DuckDB, GraphQL, SensorsData) pointing to non-existent ../sink-common-options.md. Correct path should be ../common-options/sink-common-options.md. Fix missing .md extension on datasource-spi links in common-options docs (en + zh). Fix full-width closing parenthesis in Lance zh doc URL causing 404.
Update Quick Start link from non-existent start-v2 to the correct quick-start-seatunnel-engine.md path.
- Fix broken relative links to non-existent schema-evolution.md, speed-limit.md, common-options.md and Config-Encryption-Decryption.md - Fix missing .md extensions on internal tool links in overview.md - Replace dead external URLs (Oracle XA, Lamport PDF) with working alternatives or plain-text citations - Apply fixes to both English and Chinese documentation
Correct path from ../concepts/ to ./config-encryption-decryption.md
Remove links to non-existent metrics.txt and grafana-dashboard.json files and replace with plain text descriptions.
- Add http://127.0.0.1 and src/main/java/ to dlc.json ignore patterns - Fix broken telemetry file links in English telemetry.md - Fix broken quick-start URL in English and Chinese about.md
Convert bare Wikipedia URLs to proper markdown links to prevent markdown-link-check from including trailing Chinese punctuation in the URL.
# Conflicts: # docs/en/engines/zeta/telemetry.md # docs/en/introduction/concepts/config.md # docs/en/introduction/concepts/gravitino-type-mapping.md # docs/en/introduction/how-it-works.md # docs/en/transforms/encrypt.md # docs/en/transforms/llm.md # docs/zh/engines/zeta/telemetry.md # docs/zh/introduction/concepts/config.md # docs/zh/introduction/concepts/gravitino-type-mapping.md # docs/zh/introduction/how-it-works.md # docs/zh/transforms/encrypt.md # docs/zh/transforms/llm.md
DanielLeens
approved these changes
Apr 9, 2026
DanielLeens
left a comment
DanielLeens
left a comment
There was a problem hiding this comment.
I pulled the latest HEAD locally and checked the workflow + ignore-list changes together with the touched docs / README links.
Re-enabling dead-link checking as a non-blocking continue-on-error job while tightening .dlc.json and fixing the broken repository links looks reasonable to me, and I do not see a blocker in the current revision.
corgy-w
reviewed
Apr 14, 2026
|
|
||
| ### common options [string] | ||
|
|
||
| Transform 插件的通用参数。 |
Contributor
There was a problem hiding this comment.
Why should we change these documents?
|
|
||
| ## tips | ||
| 大模型API接口通常会有速率限制，可以配合Seatunnel的限速配置，已确保任务顺利运行。 | ||
| Seatunnel限速配置请参考环境配置文档。 |
DanielLeens
approved these changes
Apr 16, 2026
DanielLeens
left a comment
DanielLeens
left a comment
There was a problem hiding this comment.
Hi @zhangshenghang,
I re-pulled the latest head locally and rechecked the workflow plus the touched docs / README links together.
Runtime chain:
backend.yml dead-link job
-> markdown-link-check -c .dlc.json
-> scans repository markdown files
-> hits the broken links fixed in this branch
The current branch still looks coherent to me:
- the dead-link job is re-enabled in
backend.yml - it stays
continue-on-error, so this is a safe “restore the monitor first” rollout .dlc.jsonnow has a usable fallback retry delay (1000msinstead of1000s)- the docs / README fixes are exactly in the set the checker would actually scan
I did not find a blocker in the current revision, and the PR checks are green.
Conclusion
Conclusion: can merge
- Blocking items
- None.
- Suggested improvements
- In a follow-up, the
.dlc.jsonignore patterns can be tightened further if we want to reduce long-term wildcard scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Re-enable the dead-link GitHub Actions job in .github/workflows/backend.yml by uncommenting the existing configuration so markdown link checking runs again in CI.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Check list