HIVE-29554: Refactor MTableColumnStatistics and MPartitionColumnStatistics to avoid code duplication#6420
Open
thomasrebele wants to merge 1 commit intoapache:masterfrom
Open
HIVE-29554: Refactor MTableColumnStatistics and MPartitionColumnStatistics to avoid code duplication#6420thomasrebele wants to merge 1 commit intoapache:masterfrom
thomasrebele wants to merge 1 commit intoapache:masterfrom
Conversation
thomasrebele
force-pushed
the
tr/HIVE-29554
branch
from
4afea6e to
a26c6ed
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
…stics to avoid code duplication
thomasrebele
force-pushed
the
tr/HIVE-29554
branch
from
a26c6ed to
3137af8
Compare
|
thomasrebele
commented
Apr 13, 2026
| this.avgColLen = avgColLen; | ||
| } | ||
|
|
||
| public void setDateStats(Long numNulls, Long numNDVs, byte[] bitVector, byte[] histogram, Long lowValue, Long highValue) { |
Contributor
Author
There was a problem hiding this comment.
There are Sonar warnings about the length of the line. The original methods in MPartitionColumnStatistics and MTableColumnStatistics had them as well. In case I make an update to the PR, I'll fix it, otherwise I would just leave that line (and setTimestampStats) as-is.
thomasrebele
commented
Apr 13, 2026
Contributor
Author
There was a problem hiding this comment.
Sonar warns about the "cognitive complexity" limit. The limit has been exceeded in the original implementation as well. I think refactoring the methods is out-of-scope for this PR, so I'll just leave them as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HIVE-29554
What changes were proposed in this pull request?
Extract a common superclass MColumnStatistics from MPartitionColumnStatistics and MColumnStatistics and combine some methods that use the latter two.
Why are the changes needed?
There is a lot of code duplication around column statistics, which increases the risk of diverging code and partially applied fixes.
Does this PR introduce any user-facing change?
No
How was this patch tested?
analyze table tab1 compute statistics for columns;. I verified the statistics withdescribe formatted tab1 a;.I started and run the DESCRIBE FORMATTED, ANALYZE TABLE, DESCRIBE FORMATTED sequence for
and vice versa, i.e.,
All commands worked as expected.