HBASE-30255 Async archiving wal file causes TestLogRolling flaky

[Apache9]

No description provided.

[Copilot]

Pull request overview

This PR addresses flakiness in AbstractTestLogRolling#testLogRolling caused by asynchronous WAL archiving by waiting until both the rolled WAL file count and tracked WAL size reach zero before asserting completion.

Changes:

• Replace HBaseTestingUtil.waitFor + immediate size assertion with an Awaitility-based untilAsserted block that waits for both conditions.
• Increase the maximum wait time to 15 seconds to accommodate async archival completion.
• Add Awaitility and Duration imports to support the new wait logic.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[PDavid]

Many thanks for fixing this. 👍

[guluo2016]

There is the same issue in TestMasterRegionWALCleaner.test()

// no archived wal files yet
assertFalse(fs.exists(globalWALArchiveDir));
region.requestRollAll();
region.waitUntilWalRollFinished();
// should have one
FileStatus[] files = fs.listStatus(globalWALArchiveDir);

Maybe we can also update the code at the same time @Apache9

[guluo2016]

Sorry, forgot to attach the error logs. Here they are:

-------------------------------------------------------------------------------
Test set: org.apache.hadoop.hbase.master.region.TestMasterRegionWALCleaner
-------------------------------------------------------------------------------
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.907 s <<< FAILURE! -- in org.apache.hadoop.hbase.master.region.TestMasterRegionWALCleaner
org.apache.hadoop.hbase.master.region.TestMasterRegionWALCleaner.test -- Time elapsed: 0.876 s <<< ERROR!
java.io.FileNotFoundException: File /home/runner/work/hbase/hbase/src/hbase-server/target/test-data/579f9f7e-bfa0-7ac2-3a7b-eacb6f71a7ce/oldWALs does not exist
	at org.apache.hadoop.fs.RawLocalFileSystem.listStatus(RawLocalFileSystem.java:798)
	at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:2078)
	at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:2122)
	at org.apache.hadoop.fs.ChecksumFileSystem.listStatus(ChecksumFileSystem.java:1020)
	at org.apache.hadoop.hbase.master.region.TestMasterRegionWALCleaner.test(TestMasterRegionWALCleaner.java:86)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.apache.hadoop.hbase.HBaseJupiterExtension.lambda$runWithTimeout$0(HBaseJupiterExtension.java:159)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:840)

[Apache9]

There is the same issue in TestMasterRegionWALCleaner.test()

// no archived wal files yet
assertFalse(fs.exists(globalWALArchiveDir));
region.requestRollAll();
region.waitUntilWalRollFinished();
// should have one
FileStatus[] files = fs.listStatus(globalWALArchiveDir);

Maybe we can also update the code at the same time @Apache9

I think you can file another issue for this one :)

[guluo2016]

I think you can file another issue for this one :)

OK, I'll create a separate PR later.