HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly

[PDavid]

The author check fails in nightly build:

hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/building-and-developing/developer-guidelines.mdx:154:Also, no `@author` tags - that's a rule.
hbase-website/public/book.html:40827:<p>Also, no <code>@author</code> tags - that’s a rule.</p>

https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1420/General_20Nightly_20Build_20Report/

Fix:
Ignore files under hbase-website in author checks.

[PDavid]

Hmm, it seems that the @author check is still failing in the general check. Does it checks it on master or on the branch? 🤔

[Apache9]

13:hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/building-and-developing/developer-guidelines.mdx:154:Also, no `@author` tags - that's a rule.
14:hbase-website/public/book.html:40827:<p>Also, no <code>@author</code> tags - that’s a rule.</p>

Seems still the same error.

[Apache9]

This is the log console output, seems we have already used the new config?

AUTHOR_IGNORE_LIST=hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/building-and-developing/developer-guidelines.mdx,hbase-website/public/book.html

[Apache9]

Oh wait a minute, what is the syntax for passing multiple ignore files in?

[Apache9]

Strange, it is comma separated... @ndimiduk do you have any ideas on this?

function author_parse_args
{
  declare i

  for i in "$@"; do
    case ${i} in
      --author-ignore-list=*)
        delete_parameter "${i}"
        yetus_comma_to_array AUTHOR_IGNORE_LIST "${i#*=}"
      ;;
    esac
  done
}

[PDavid]

Maybe we need space separator, let's see. 🙈

[ndimiduk]

https://issues.apache.org/jira/browse/YETUS-1266

[ndimiduk]

apache/yetus#366

[PDavid]

Many thanks @ndimiduk for your fix in Yetus! 👍

I guess we will have to wait until the new Yetus release and then upgrade Yetus in HBase, right?

[ndimiduk]

Many thanks @ndimiduk for your fix in Yetus! 👍

I guess we will have to wait until the new Yetus release and then upgrade Yetus in HBase, right?

Yes, unfortunately. Maybe you can re-implement the fix as a function override in our personality file -- bash is extremely monkey-patchable.

[PDavid]

Hi @ndimiduk,

I tried to do the monkey-patching thing but to be honest I'm not sure if I'm doing it right. It does not work for sure. I cannot see my newly added debug messages in the output log. 🙈

Can you please help in this a bit?

[Apache9]

We can try to use the lastest master of yetus to see if it helps? If so, we can push yetus to release a new version.

[ndimiduk]

Anything that I can make better back on the Yetus side?

[ndimiduk]

Lolsob

[PDavid]

Thanks, yes, I'll need to remove this. 😄

[PDavid]

So this proves that the monkey-patch function IS actually invoked:

[PDavid]

Removed the debug logging now.

[PDavid]

General question:

Turns out for GitHup PR-s, the author_patchfile function is invoked which is for patch mode. So that is a different function than what we have the fix in yetus and the monkey-patch for. This means that the author check will fail on the PR.
But the nightly author check should be fixed by this patch.

Is it OK to merge it like this (as I hope it will fix the nightly)?
What do you all think?

[PDavid]

I tried to hack something for the author_patchfile function (which is for patch mode) with Claude Code as I'm not too experienced with Yetus but it was not successful unfortunately. 😢

[PDavid]

@ndimiduk and @Apache9 can you please have a look?