Skip to content

[fix](fe) Cancel rebuilt VCG warm up jobs on drop#65426

Open
deardeng wants to merge 1 commit into
apache:masterfrom
deardeng:fix-vcg-warmup-job-ids
Open

[fix](fe) Cancel rebuilt VCG warm up jobs on drop#65426
deardeng wants to merge 1 commit into
apache:masterfrom
deardeng:fix-vcg-warmup-job-ids

Conversation

@deardeng

@deardeng deardeng commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Problem Summary: When active/standby switches for a virtual compute group, FE rebuilds periodic and event-driven file cache warm up jobs and writes new job ids to MS. FE memory kept stale cacheWarmupJobIds until a later MS sync, so a quick DROP VCG cancelled old ids and left rebuilt jobs running. This change makes updateFileCacheJobIds report MS update success, synchronizes the FE-local policy with rebuilt job ids after a successful update, and cancels newly created jobs if the MS update fails.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

### What problem does this PR solve?

Issue Number: close apache#26980

Related PR: apache#65153

Problem Summary: When active/standby switches for a virtual compute group, FE rebuilds periodic and event-driven file cache warm up jobs and writes new job ids to MS. FE memory kept stale cacheWarmupJobIds until a later MS sync, so a quick DROP VCG cancelled old ids and left rebuilt jobs running. This change makes updateFileCacheJobIds report MS update success, synchronizes the FE-local policy with rebuilt job ids after a successful update, and cancels newly created jobs if the MS update fails.

### Release note

Fixes VCG drop cleanup after warm up job rebuild.

### Check List (For Author)

- Test: Unit Test
    - ./run-fe-ut.sh --run org.apache.doris.cloud.catalog.CloudInstanceStatusCheckerTest#testDropVirtualComputeGroupCancelsRebuiltWarmUpJobs
    - ./run-fe-ut.sh --run org.apache.doris.cloud.catalog.CloudInstanceStatusCheckerTest#testRebuildCancelsNewWarmUpJobsWhenUpdateJobIdsFails
    - ./run-fe-ut.sh --run org.apache.doris.cloud.catalog.CloudInstanceStatusCheckerTest
- Behavior changed: Yes. Drop VCG now cancels rebuilt warm up jobs after active/standby switch.
- Does this need documentation: No
@deardeng deardeng requested a review from gavinchou as a code owner July 9, 2026 12:43
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants