tests: add count-min C++ serialization compatibility tests#92
Draft
PsiACE wants to merge 2 commits into
Draft
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Failed on Windows. Perhaps related to line separator? |
Member
|
Looks like when generating the cpp snapshot, it prints CRLF on windows. Should work with their people like @proost |
Member
|
WRT Windows and CRLF issues. I noticed that there is no .gitattributes file in ds-cpp. I ran into similar issues recently when refactoring ds-memory. It turns out all the major modern OSs can correctly process text files with just LF "\n" line endings. So structuring the .gitattributes file to force LF endings for all text type files fixed the problem and it works for Ubuntu, MacOS, and Windows. See this .gitattributes. |
Member
|
@PsiACE the corresponding cpp patch has been merged. You may rebase this patch and pin the cpp checkout to the latest commit and retry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.