[branch-54] Fix: compact view buffers in ScalarValue::compact for all container types (#21934)#22446
Open
alamb wants to merge 1 commit into
Open
[branch-54] Fix: compact view buffers in ScalarValue::compact for all container types (#21934)#22446alamb wants to merge 1 commit into
alamb wants to merge 1 commit into
Conversation
apache#21934) ## Which issue does this PR close? - Closes apache#21928. ## Rationale for this change ScalarValue::compact copies array data for container types to release sliced-buffer overhead, but never called .gc() on nested StringViewArray / BinaryViewArray. A scalar extracted from a large batch would therefore still hold a reference to the entire original view backing buffer, negating the benefit of compaction for any list, struct, or map whose values are view-typed. ## What changes are included in this PR? - ScalarValue::compact now compacts nested view buffers for all container types (List, LargeList, FixedSizeList, ListView, LargeListView, Struct, Map), trimming StringViewArray / BinaryViewArray backing buffers to only the referenced bytes. - The internal compact_view_buffers helper recursively handles FixedSizeList, ListView, LargeListView, and Map. ## Are these changes tested? new unit tests are added in scalar::tests, one per container type. Each test verifies that after compact() the backing buffer is reduced to exactly the bytes of the referenced string, and that the scalar value is preserved. ## Are there any user-facing changes? No. The public compact / compacted API is unchanged; this PR only fixes the behaviour for view-typed nested arrays. Co-authored-by: Bert Vermeiren <bert.vermeiren@datadobi.com> Co-authored-by: Dmitrii Blaginin <dmitrii@blaginin.me> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks the fix for
ScalarValue::compactto compact view buffers for all container types ontobranch-54.