Skip to content

Add zstd to makefile routing #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
reshke wants to merge 1 commit into from
+4 −0
Closed

Add zstd to makefile routing #1802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions gpcontrib/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,16 @@ install:
@if [ "$(enable_orafce)" = "yes" ]; then \
$(MAKE) -C orafce NO_PGXS=true install; \
fi
@if [ "$(with_zstd)" = "yes" ]; then \
Copy link
Copy Markdown
Contributor

@my-ship-it my-ship-it Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @reshke thanks for the patch!

▎ How does it even work without this?

It works through the recurse mechanism that's already in place. A few lines above in the same Makefile:

ifeq "$(with_zstd)" "yes"
recurse_targets += zstd
endif
...
$(call recurse,all install clean distclean, $(recurse_targets))

The recurse function (defined in src/Makefile.global.in) uses $(eval) to generate, for each target/subdir pair:

install: install-zstd-recurse
install-zstd-recurse: submake-generated-headers
$(MAKE) -C zstd install

Since GNU make allows adding prerequisites to a target whose recipe is defined elsewhere, the explicit install: recipe below picks up
install-zstd-recurse as a prerequisite — so make install already descends into zstd/ before running the gpcloud/mapreduce/pxf/orafce steps. Same for
all, clean, and distclean.

This is easy to verify with a dry run:

$ make -n -C gpcontrib install | grep "zstd install"
make -C zstd install

With this patch applied, make -C zstd install (and clean) would run twice — harmless, but redundant.

$(MAKE) -C zstd install; \
fi

clean:
if [ "$(enable_mapreduce)" = "yes" ]; then $(MAKE) -C gpmapreduce clean; fi
if [ "$(enable_gpcloud)" = "yes" ]; then $(MAKE) -C gpcloud cleanall; fi
if [ "$(enable_pxf)" = "yes" ]; then $(MAKE) -C pxf_fdw clean; fi
if [ "${enable_orafce}" = "yes" ]; then $(MAKE) -C orafce NO_PGXS=true clean; fi
if [ "$(with_zstd)" = "yes" ]; then $(MAKE) -C zstd clean; fi


distclean:
Expand Down
Loading