MINOR: [C++][Gandiva] cast to unsigned char before ctype calls#50124
Open
metsw24-max wants to merge 1 commit into
Open
MINOR: [C++][Gandiva] cast to unsigned char before ctype calls#50124metsw24-max wants to merge 1 commit into
metsw24-max wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Out-of-range argument passed to ctype functions
The Gandiva string and time helpers feed raw
charbytes intoisdigit/isxdigit/isalpha/toupper. Wherecharis signed, any byte above 0x7f (so any multi-byte UTF-8 value in untrusted column data) is sign-extended to a negativeint, which sits outside theunsigned char/EOFdomain those functions are defined for. glibc tolerates it, but a strict ctype table indexes before its lookup array. Cast each argument tounsigned charat the call site, the waygdv_function_stubs.ccalready does. Reviewer note: this is the same swept across both files so no instance is left behind.