test(parquet/file): add regression test for mixed-size ByteArray WriteBatch #757
Open
kli19 wants to merge 1 commit intoapache:mainfrom
Open
test(parquet/file): add regression test for mixed-size ByteArray WriteBatch #757kli19 wants to merge 1 commit intoapache:mainfrom
kli19 wants to merge 1 commit intoapache:mainfrom
Conversation
kli19
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Issue #756 reports that small ByteArray values are silently dropped when a large (≥1MB) value appears in the same WriteBatch. This was already fixed on main by #690, but there was no test covering the specific mixed-size scenario.
What changes are included in this PR?
Adds a regression test that writes a batch of mixed-size ByteArray values (small values flanking a 2MB value) and verifies all values round-trip correctly.
Are these changes tested?
The test itself is the change. Confirmed it fails at bbf7ab7 (#655, the buggy commit) and passes on main.
Are there any user-facing changes?
No