fix(site): otk-task-list-simple default padding and content height#9607
fix(site): otk-task-list-simple default padding and content height#9607chenshuai2144 wants to merge 1 commit intomasterfrom
Conversation
Add dumi entry Less for Agentic task list: padding 0 4px on root, height 0 on content wrapper per design defaults. Co-authored-by: 陈帅 <wasd2144@hotmail.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request integrates a new LESS stylesheet, otkTaskListSimpleSiteDefaults.less, into the site-dumi-plugin to define default styles for the Agentic task list. The review feedback suggests improving the maintainability and readability of the new LESS file by nesting the .otk-task-list-simple-content selector within .otk-task-list-simple and adding a blank line after the initial comment.
| // 文档/演示中嵌入的 Agentic 任务列表:站点侧默认与组件库一致 | ||
| .otk-task-list-simple { | ||
| padding: 0 4px; | ||
| } | ||
|
|
||
| .otk-task-list-simple-content { | ||
| height: 0; | ||
| } |
There was a problem hiding this comment.
For better maintainability and to follow Less best practices, consider nesting the .otk-task-list-simple-content selector within .otk-task-list-simple using the & operator. This makes the relationship between the classes clearer and keeps the code more organized. Additionally, adding a blank line after the initial comment improves readability.
// 文档/演示中嵌入的 Agentic 任务列表:站点侧默认与组件库一致
.otk-task-list-simple {
padding: 0 4px;
&-content {
height: 0;
}
}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9607 +/- ##
==========================================
- Coverage 88.53% 88.48% -0.05%
==========================================
Files 368 368
Lines 11257 11257
Branches 4157 4154 -3
==========================================
- Hits 9966 9961 -5
- Misses 1139 1143 +4
- Partials 152 153 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Set site (dumi) defaults for embedded Ant Design Agentic task list classes:
.otk-task-list-simple:padding: 0 4px.otk-task-list-simple-content:height: 0Changes
site/theme/otkTaskListSimpleSiteDefaults.lesssite-dumi-plugin.tsviaaddEntryImports(same pattern asmarkdownExternalLink.less)