Skip to content

fix(site): otk-task-list-simple default padding and content height#9607

Draft
chenshuai2144 wants to merge 1 commit intomasterfrom
cursor/otk-task-list-simple-site-defaults-3cf6
Draft

fix(site): otk-task-list-simple default padding and content height#9607
chenshuai2144 wants to merge 1 commit intomasterfrom
cursor/otk-task-list-simple-site-defaults-3cf6

Conversation

@chenshuai2144
Copy link
Copy Markdown
Contributor

Summary

Set site (dumi) defaults for embedded Ant Design Agentic task list classes:

  • .otk-task-list-simple: padding: 0 4px
  • .otk-task-list-simple-content: height: 0

Changes

  • New site/theme/otkTaskListSimpleSiteDefaults.less
  • Import it from site-dumi-plugin.ts via addEntryImports (same pattern as markdownExternalLink.less)

Submitted by Cursor

Open in Web Open in Cursor 

Add dumi entry Less for Agentic task list: padding 0 4px on root,
height 0 on content wrapper per design defaults.

Co-authored-by: 陈帅 <wasd2144@hotmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6e7d8329-d0ab-497e-a0d3-f7c68193ec65

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/otk-task-list-simple-site-defaults-3cf6

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates a new LESS stylesheet, otkTaskListSimpleSiteDefaults.less, into the site-dumi-plugin to define default styles for the Agentic task list. The review feedback suggests improving the maintainability and readability of the new LESS file by nesting the .otk-task-list-simple-content selector within .otk-task-list-simple and adding a blank line after the initial comment.

Comment on lines +1 to +8
// 文档/演示中嵌入的 Agentic 任务列表:站点侧默认与组件库一致
.otk-task-list-simple {
padding: 0 4px;
}

.otk-task-list-simple-content {
height: 0;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability and to follow Less best practices, consider nesting the .otk-task-list-simple-content selector within .otk-task-list-simple using the & operator. This makes the relationship between the classes clearer and keeps the code more organized. Additionally, adding a blank line after the initial comment improves readability.

// 文档/演示中嵌入的 Agentic 任务列表:站点侧默认与组件库一致

.otk-task-list-simple {
  padding: 0 4px;

  &-content {
    height: 0;
  }
}

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.48%. Comparing base (bdbf841) to head (b4330cf).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9607      +/-   ##
==========================================
- Coverage   88.53%   88.48%   -0.05%     
==========================================
  Files         368      368              
  Lines       11257    11257              
  Branches     4157     4154       -3     
==========================================
- Hits         9966     9961       -5     
- Misses       1139     1143       +4     
- Partials      152      153       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants