fix: preserve multi-hash comments on ansible-lint --fix#5033
Open
bishalOps wants to merge 1 commit intoansible:mainfrom
Open
fix: preserve multi-hash comments on ansible-lint --fix#5033bishalOps wants to merge 1 commit intoansible:mainfrom
ansible-lint --fix#5033bishalOps wants to merge 1 commit intoansible:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found another bug while using
ansible-lint --fixwhere any comment starting with ## (or ###, etc.) was getting mangled into # #. I swapped the existing logic for a small regex that just adds a space after the leading run of #s when one's missing, and otherwise leaves things alone.