fix: preserve trailing blank lines when fqcn auto-fix renames a key#5027
Open
bishalOps wants to merge 1 commit intoansible:mainfrom
Open
fix: preserve trailing blank lines when fqcn auto-fix renames a key#5027bishalOps wants to merge 1 commit intoansible:mainfrom
bishalOps wants to merge 1 commit intoansible:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ansible-lint --fix for fqcn[*]was dropping blank lines between tasks, and also trailing comments, when the renamed key was the last key in a task mapping (#4543). Inruamel.yaml, blank-line and trailing-comment metadata are stored inca.itemskeyed by the original mapping key. The transform removes and reinserts the renamed key, but does not rebindca.items, so the metadata is left orphaned under the old key name and the YAML emitter drops it. This fix migratesca.items[old_key]toca.items[new_key]after renaming so the formatting metadata is preserved during emission