Skip to content

fix: Evaluate the exit code after applying the skipped rules from .ansible-lint-ignore - #5001

Merged
Hrithik-Gavankar merged 5 commits into
ansible:mainfrom
gmuloc:issue/4997
Jun 2, 2026
Merged

fix: Evaluate the exit code after applying the skipped rules from .ansible-lint-ignore#5001
Hrithik-Gavankar merged 5 commits into
ansible:mainfrom
gmuloc:issue/4997

Conversation

@gmuloc

@gmuloc gmuloc commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Fixes #4997

@gmuloc
gmuloc requested a review from a team as a code owner March 27, 2026 09:56
@github-actions github-actions Bot added the fix label Mar 27, 2026
@ssbarnea
ssbarnea marked this pull request as draft March 31, 2026 16:24
@ssbarnea

Copy link
Copy Markdown
Member

Please bring it out of draft once it passed CI.

@gmuloc

gmuloc commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

Please bring it out of draft once it passed CI.

Can you please advise on the CI failing? it looks that some of the tox failures are not related to this PR?

@gmuloc
gmuloc marked this pull request as ready for review April 23, 2026 14:01
@kpfleming

Copy link
Copy Markdown

I've just run into this as well, I have quite a few skip rules and now I get a failure response when no failures were found.

@gmuloc Maybe updating this branch to the current contents of main will get the CI workflows to succeed?

@gmuloc

gmuloc commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

I've just run into this as well, I have quite a few skip rules and now I get a failure response when no failures were found.

@gmuloc Maybe updating this branch to the current contents of main will get the CI workflows to succeed?

giving it a try!

@kpfleming

Copy link
Copy Markdown

It worked! @ssbarnea this should be ready for final review now.

@Hrithik-Gavankar Hrithik-Gavankar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@Hrithik-Gavankar
Hrithik-Gavankar merged commit 4d632f0 into ansible:main Jun 2, 2026
22 checks passed
@github-project-automation github-project-automation Bot moved this from Review to Done in 🧰 devtools project board Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Exit code 2 when all warnings are skipped using .ansible-lint-ignore and --strict

4 participants