Refactor read_chunk to eliminate possible compiler warning#65
Open
Refactor read_chunk to eliminate possible compiler warning#65
Conversation
Previous code could cause a compiler warning with overly-pedantic settings: 'value' may be used uninitialized Previous behavior was correct, only initialized values would be read. New version also has simpler logic.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 95.84% 95.77% -0.07%
==========================================
Files 22 22
Lines 1563 1561 -2
Branches 176 173 -3
==========================================
- Hits 1498 1495 -3
- Misses 65 66 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous code could cause a compiler warning with overly-pedantic settings: 'value' may be used uninitialized
Previous behavior was correct, only initialized values would be read. New version also has simpler logic.