Closed
Conversation
Contributor
kaitlinbolling
left a comment
There was a problem hiding this comment.
@juliobranha it looks like this is no longer needed, as WP automatically inserts a skip link on block themes that include a <main> tag. I think we should prefer core's implementation rather than introducing our own. I know I originally filed this issue -- I'm sorry for not noticing this sooner!
See: https://developer.wordpress.org/reference/functions/wp_enqueue_block_template_skip_link/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #43
This pull request introduces a "Skip to Content" accessibility feature to enhance keyboard and screen reader navigation:
_a11y.scss) and layout (_layout.scss) in theassets/scss/directory._a11y.scssincludes ascreen-reader-onlymixin to visually hide content while keeping it accessible to assistive technologies, and askip-linkmixin to style skip navigation links for visibility when focused._layout.scssintroduces anauto-marginsmixin for horizontally centering elements..screen-reader-text(for visually hidden, screen reader-accessible content).skip-link(for styling the skip link)Testing Instructions
Checklist