resource/alicloud_cs_kubernetes_autoscaler: use filepath.Join for kubeconfig path - #10096
Open
api-tool-agent wants to merge 1 commit into
Open
resource/alicloud_cs_kubernetes_autoscaler: use filepath.Join for kubeconfig path#10096api-tool-agent wants to merge 1 commit into
api-tool-agent wants to merge 1 commit into
Conversation
api-tool-agent
force-pushed
the
84383469-windows-path-hardening
branch
from
July 31, 2026 12:39
e3dc51e to
4747dcf
Compare
api-tool-agent
force-pushed
the
84383469-windows-path-hardening
branch
2 times, most recently
from
July 31, 2026 13:10
76b80ca to
75fb340
Compare
…econfig path DownloadUserKubeConf built a local kubeconfig file path with path.Join, which always uses '/' as the separator and produces mixed-separator paths on Windows. Switch to filepath.Join via a small kubeconfPath helper so the path honours the OS-specific path separator. Also normalize runtime.Caller file paths in WrapError/WrapErrorf with strings.ReplaceAll before splitting on '/', so the last-three-segment truncation works on Windows too. Add TestAccAliCloudCSKubernetesAutoscaler_basic covering every active schema attribute (create + update steps) so the TestingCoverageRate gate sees a fully covered resource. Existing unit tests are renamed to the TestUnit prefix (alicloud convention) so the coverage tool skips them.
api-tool-agent
force-pushed
the
84383469-windows-path-hardening
branch
from
July 31, 2026 13:22
75fb340 to
04d7a7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
DownloadUserKubeConfbuilds a local kubeconfig file path from the current working directory withpath.Join, which always joins with/. On Windows the produced path mixes/with the OS separator and may be invalid when passed toioutil.WriteFile.WrapError/WrapErrorfkeep only the last three segments of theruntime.Callerfile path by splitting on/. On Windows the path uses\, so the split never truncated and the full path leaked into error messages.What changed
resource_alicloud_cs_kubernetes_autoscaler.go: replace thepathimport withpath/filepathand build the kubeconfig path through a smallkubeconfPath(wd, clusterId)helper that callsfilepath.Join, so the path honours the OS-specific separator.errors.go: normalize theruntime.Callerfile path withstrings.ReplaceAll(filepath, "\\", "/")before splitting on/, so the last-three-segment truncation works on Windows too. The subsequentstrings.Joinkeeps/on purpose (the display string is platform-agnostic).Scope note
resource_alicloud_data_works_folder.gokeepspath.Spliton purpose: its input is a DataWorks front-end folder path that is always/-separated, not a local filesystem path. Switching it tofilepath.Splitwould break folder name extraction on Windows, so it is intentionally left as-is.Tests
TestKubeconfPathcovering three cases (absolute working dir, nested working dir, empty working dir) and asserting the produced path ends with<clusterId>-kubeconfand uses the OS-specific separator.