sfmMerge/alignment: fix computeSimilarityFromCommonLandmarks and extract from fromLandmarksMerge#2102
Open
sfmMerge/alignment: fix computeSimilarityFromCommonLandmarks and extract from fromLandmarksMerge#2102
Conversation
Agent-Logs-Url: https://github.com/alicevision/AliceVision/sessions/63e50d0a-ecf5-4f34-8176-8cb34a8a314e Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
fabiencastan
March 28, 2026 02:28
View session
Agent-Logs-Url: https://github.com/alicevision/AliceVision/sessions/9ce4507a-fd37-4233-99c7-c9fdbbea5342 Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FROM_FEATURE_MATCHEStoEAlignmentMethodenum inmain_sfmAlignment.cppEAlignmentMethod_enumToStringandEAlignmentMethod_stringToEnumto handle the new valuematchesFoldersanddescriberTypesNamecommand-line parameters (-m/--matchesFoldersand-d/--describerTypes)matching/MatchesCollections.hpp,matching/io.hpp,<random>)FROM_FEATURE_MATCHEScase to the switch statement, callingcomputeSimilarityFromCommonLandmarkswithpairwiseMatchesfrom_landmarksmethod description ("Alilgn" → "Align")📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.