Skip to content

segment trees questions added#10

Open
Manish2397 wants to merge 1 commit intoalgoholics-ntua:masterfrom
Manish2397:master
Open

segment trees questions added#10
Manish2397 wants to merge 1 commit intoalgoholics-ntua:masterfrom
Manish2397:master

Conversation

@Manish2397
Copy link
Copy Markdown

Segment trees tutorial with question added.

@papachristoumarios
Copy link
Copy Markdown
Member

Hello @Manish2397,

This seems to be code for segment trees. Your PR is labeled as questions for segment trees.
Also consider formatting your code well and adding testcases to it.

@mstou
Copy link
Copy Markdown
Member

mstou commented Sep 27, 2019

Hello @Manish2397 , thanks for contributing. Can you please move the Segment tree folder to Data Structures/ Advanced DS/ Segment Trees instead of the root folder so as to follow the structure described in README?

We would also like you to provide a more thorough documentation of the code, as also indicated by @papachristoumarios.

Lastly, instead of implementing 2 segment trees (one for min/max querries and one for range sum querries) you could implement 1 generic segment tree that works with a function f (int f(int x, int y)). In the first case f would be int f(int x, int y){ return min(x,y); } and in the range sum segment tree it would be: int f(int x, int y){ return x+y; }

//right subTree
buildSegmentTree(tree,values,2*index+1,mid+1,end);

tree[index] = tree[2*index]+tree[2*index+1];
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, in the generic segment tree described in my comment, line 22 would be:
tree[index] = f( tree[2*index], tree[2*index+1] );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants