fix: fall back to inline image data for internal URIs#228
Merged
benbrandt merged 2 commits intoJun 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http:,https:, anddata:image URLs.zed:///agent/pasted-image?...input.Motivation
Some ACP clients attach pasted images with inline
data/mimeTypeplus a client-internaluri. For example, Zed can send a pasted image URI such aszed:///agent/pasted-image?name=Image. The adapter currently forwards that URI to Codex as an image URL, which later becomes an OpenAIimage_urlvalue and is rejected becausezed:///...is not a valid URL for the API.Using the inline image payload for non-fetchable URI schemes preserves image input while still allowing real external URLs and already-inline
data:URLs to pass through unchanged.Validation
npm test -- src/__tests__/CodexACPAgent/CodexAcpClient.test.tsnpm run typecheck