[ refactor ] Make Data.Irrelevant.Irrelevant a proper Monad#2977
Merged
jamesmckinna merged 2 commits intoagda:masterfrom Apr 20, 2026
Merged
[ refactor ] Make Data.Irrelevant.Irrelevant a proper Monad#2977jamesmckinna merged 2 commits intoagda:masterfrom
Data.Irrelevant.Irrelevant a proper Monad#2977jamesmckinna merged 2 commits intoagda:masterfrom
Conversation
Member
|
This looks very useful! |
jamesmckinna
commented
Apr 12, 2026
MatthewDaggitt
approved these changes
Apr 13, 2026
JacquesCarette
approved these changes
Apr 17, 2026
Collaborator
JacquesCarette
left a comment
There was a problem hiding this comment.
Up to naming, I think this is a great change.
gallais
approved these changes
Apr 20, 2026
Member
gallais
left a comment
There was a problem hiding this comment.
I did not like the original names but could not think of any fix.
The new ones make a lot of sense!
Collaborator
Author
|
Thanks everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is prompted by this comment and @gallais 's introduction of the
λ∙operator which shifts irrelevant application to ordinary application. In some sense, this PR offers the converse operation, provided the codomain isIrrelevant.Rationale:
Data.Irrelevant._>>=_now has that of a 'proper' monadicbindoperator, which increases the range of its applicability wrt its type, but also permits the use ofdo-notation etc. downstreamDetails:
irrelevant-recomputemoves (asrecompute) toData.IrrelevantRelation.Nullary.RecomputableBadged as
v2.4, because AFAICT this is a backwards-compatible (if fiddly) change.Potential consequences: downstream, we can reconsider all (?) uses of the
.modality in favour of theIrrelevantmodality, and otherwise leave it encapsulated inData.Irrelevant?