[DEL] agrios_kobo: agrios dependency#44
Open
thomaspaulb wants to merge 1 commit intoadvanceinsight:18.0from
Open
[DEL] agrios_kobo: agrios dependency#44thomaspaulb wants to merge 1 commit intoadvanceinsight:18.0from
thomaspaulb wants to merge 1 commit intoadvanceinsight:18.0from
Conversation
Contributor
|
@thomaspaulb But there are still factual dependencies on agrios, like the use of the farmer.training model. Also there is a dependency on farmer.plot, that now should become model geospatial.plot, which then would need a depends on geospatial_plot. |
Author
|
@NL66278 So where is farmer.training defined? Then we could depend on that specific module, as well as geospatial_plot. |
Contributor
|
@thomaspaulb it is defined in agrios_training (which in turn depends on agrios_farmer). Actually there is a lot to be said for OCA'izing the agrios_training module as well, as giving training, organizing groups of people to be trained, giving out certificates for training followed (or examinations passed) does not seem very specific for farmers... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
agriosmodule which is being depended on, does not exist.I couldn't identify other AgriOS modules that this should depend on, there seem to be no models or views inherited from other AgriOS modules.