http: add h1 write buffer size setting#3986
Merged
JohnTitor merged 1 commit intoactix:mainfrom Apr 18, 2026
Merged
Conversation
JohnTitor
commented
Mar 26, 2026
| } | ||
| } | ||
|
|
||
| struct ReadyChunkBody { |
Member
Author
There was a problem hiding this comment.
This is written by agent and I know it's too defensive. I feel ok as it's no harm as long as it's a test, but let me know if you dislike it.
JohnTitor
commented
Mar 26, 2026
| StateProj::SendPayload { mut body } => { | ||
| // keep populate writer buffer until buffer size limit hit, | ||
| // get blocked or finished. | ||
| while this.write_buf.len() < super::payload::MAX_BUFFER_SIZE { |
Member
Author
There was a problem hiding this comment.
Maybe we can clean up this old const later 🤔
Co-authored-by: Nicolas Grondin <ngrondin78@gmail.com>
JohnTitor
force-pushed
the
h1-write-buf-size
branch
from
3c82372 to
b7cdcb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
PR_TYPE
PR Checklist
Overview
Modernized version of #3662
Close #3662