Skip to content

add typescript types#662

Closed
Rishabh060105 wants to merge 1 commit intoaccordproject:mainfrom
Rishabh060105:Rishabh060105/add-typescript-types
Closed

add typescript types#662
Rishabh060105 wants to merge 1 commit intoaccordproject:mainfrom
Rishabh060105:Rishabh060105/add-typescript-types

Conversation

@Rishabh060105
Copy link
Copy Markdown

Closes #648

Adds package-level TypeScript declaration entrypoints across the published markdown-transform packages so TypeScript consumers can resolve typings directly from npm.

Changes

  • Added index.d.ts entrypoints for the published packages: markdown-transform, markdown-template, markdown-common, markdown-cicero, markdown-html, markdown-it-template, markdown-it-cicero, and markdown-cli
  • Updated package manifests to publish those declaration files through files and typings, and exported generateTransformationDiagram from the top-level @accordproject/markdown-transform entrypoint so the package API matches the documented README usage

Flags

  • This PR is opened from Rishabh060105/add-typescript-types on a fork targeting accordproject/markdown-transform:main
  • The implementation was validated locally with npm install and npm test; no UI or screenshot-based validation applies for this change

Screenshots or Video

  • Not applicable

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from Rishabh060105/add-typescript-types

Signed-off-by: Rishabh Jain <rishabhj2005@gmail.com>
@Rishabh060105
Copy link
Copy Markdown
Author

Hi @mttrbrts, I picked up the TypeScript typings work from #648 and pushed a first pass for review.

What changed:

  • added package-level index.d.ts entrypoints for the published packages
  • updated each package manifest to publish and advertise those declarations via files and typings
  • fixed the top-level @accordproject/markdown-transform export surface so generateTransformationDiagram is available as documented

Validation:

  • ran npm install
  • ran npm test

The branch is based on the fork branch Rishabh060105/add-typescript-types and is intended to address #648. If you want, I can also tighten the typings further or add any package-specific refinements before review.

@mttrbrts
Copy link
Copy Markdown
Member

mttrbrts commented May 7, 2026

Thanks for this contribution! This appears to be a duplicate of #649 by @salama968, which was opened earlier and addresses the same issue (#648).

@Rishabh060105 — would you mind helping review #649? If Copilot adds feedback there, your input would be valuable since you've worked on the same feature.

@mttrbrts mttrbrts closed this May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Typescript types

2 participants