add typescript types#662
Closed
Rishabh060105 wants to merge 1 commit intoaccordproject:mainfrom
Closed
Conversation
Signed-off-by: Rishabh Jain <rishabhj2005@gmail.com>
Author
|
Hi @mttrbrts, I picked up the TypeScript typings work from #648 and pushed a first pass for review. What changed:
Validation:
The branch is based on the fork branch |
Member
|
Thanks for this contribution! This appears to be a duplicate of #649 by @salama968, which was opened earlier and addresses the same issue (#648). @Rishabh060105 — would you mind helping review #649? If Copilot adds feedback there, your input would be valuable since you've worked on the same feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #648
Adds package-level TypeScript declaration entrypoints across the published
markdown-transformpackages so TypeScript consumers can resolve typings directly from npm.Changes
index.d.tsentrypoints for the published packages:markdown-transform,markdown-template,markdown-common,markdown-cicero,markdown-html,markdown-it-template,markdown-it-cicero, andmarkdown-clifilesandtypings, and exportedgenerateTransformationDiagramfrom the top-level@accordproject/markdown-transformentrypoint so the package API matches the documented README usageFlags
Rishabh060105/add-typescript-typeson a fork targetingaccordproject/markdown-transform:mainnpm installandnpm test; no UI or screenshot-based validation applies for this changeScreenshots or Video
Related Issues
Author Checklist
--signoffoption of git commit.mainfromRishabh060105/add-typescript-types