fix: verify consensus rpc chain_id during startup#791
Open
0xpinara wants to merge 1 commit intoa16z:masterfrom
Open
fix: verify consensus rpc chain_id during startup#7910xpinara wants to merge 1 commit intoa16z:masterfrom
0xpinara wants to merge 1 commit intoa16z:masterfrom
Conversation
Call the existing check_rpc() method after sync completes to verify the consensus RPC's chain_id matches the configured network. If there's a mismatch, the client stops with an IncorrectRpcNetwork error instead of silently serving data from the wrong chain. Closes a16z#544
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Calls the existing but unused
Inner::check_rpc()method after sync completes. If the consensus RPC serves a different chain than configured, the client stops withIncorrectRpcNetworkinstead of silently returning the wrong chain_id.Changes
ethereum/src/consensus.rs— callcheck_rpc()after sync, before marking client as syncedCloses #544