Build system fixes & Discord RPC update#187
Open
ThePotato97 wants to merge 10 commits intoZaarrg:webview-windowsfrom
Open
Build system fixes & Discord RPC update#187ThePotato97 wants to merge 10 commits intoZaarrg:webview-windowsfrom
ThePotato97 wants to merge 10 commits intoZaarrg:webview-windowsfrom
Conversation
Owner
|
thanks for the amazing pr, will review and merge when i have time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned up the build process so it actually works without manual trial and error. Also updated Discord RPC fields.
Build stuff:
vcpkg.jsonso dependencies install themselves.out/.Discord RPC:
name,statusDisplayType, etc).SetDiscordVideoPresence,SetDiscordDiscoverPresence, andSetDiscordMetaDetailPresenceto actually use the new display types.CI & Other stuff:
.gitignoreso the repo stays clean.just run
cmake -S . -B outand it should build fine.