Security: Use aria-controls instead of href in link category tab#12625
Security: Use aria-controls instead of href in link category tab#12625SainathPoojary wants to merge 2 commits into
aria-controls instead of href in link category tab#12625Conversation
There was a problem hiding this comment.
Pull request overview
Updates the link category tab-switching logic in the admin Link editor to use aria-controls as the source of the target panel ID, aligning tab behavior more closely with ARIA semantics and reducing reliance on href values.
Changes:
- Read the target tab panel from
aria-controlsrather thanhref. - Update tab-panel selection and the “All categories” comparison to match the new
aria-controlsvalue format (no leading#).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $('.tabs-panel').hide(); | ||
| $(t).show(); | ||
| if ( '#categories-all' == t ) { | ||
| $( '#' + t ).show(); |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac ticket: #65573