Skip to content

Security: Use aria-controls instead of href in link category tab#12625

Open
SainathPoojary wants to merge 2 commits into
WordPress:trunkfrom
SainathPoojary:fix/65573
Open

Security: Use aria-controls instead of href in link category tab#12625
SainathPoojary wants to merge 2 commits into
WordPress:trunkfrom
SainathPoojary:fix/65573

Conversation

@SainathPoojary

Copy link
Copy Markdown

Trac ticket: #65573

Copilot AI review requested due to automatic review settings July 21, 2026 12:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the link category tab-switching logic in the admin Link editor to use aria-controls as the source of the target panel ID, aligning tab behavior more closely with ARIA semantics and reducing reliance on href values.

Changes:

  • Read the target tab panel from aria-controls rather than href.
  • Update tab-panel selection and the “All categories” comparison to match the new aria-controls value format (no leading #).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/js/_enqueues/admin/link.js Outdated
$('.tabs-panel').hide();
$(t).show();
if ( '#categories-all' == t ) {
$( '#' + t ).show();
@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copilot AI review requested due to automatic review settings July 21, 2026 15:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@SainathPoojary
SainathPoojary marked this pull request as ready for review July 21, 2026 15:05
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sainathpoojary.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants