enhancement(checks): add check for changing error reporting configuration#1321
Open
faisalahammad wants to merge 1 commit into
Open
enhancement(checks): add check for changing error reporting configuration#1321faisalahammad wants to merge 1 commit into
faisalahammad wants to merge 1 commit into
Conversation
- Add ErrorReportingSniff to phpcs-sniffs - Add Error_Reporting_Check to core checks - Add PHPUnit unit tests and dummy plugins for verification Fixes WordPress#1272
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
|
Wow Faisal, thanks for the quick response. I'll check the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new static check to identify cases where plugin code changes PHP error reporting or WordPress debug configuration at runtime. This prevents plugins from disrupting global debug configurations or hiding critical errors in production environments.
Fixes #1272
Changes
phpcs-sniffs/PluginCheck/Sniffs/CodeAnalysis/ErrorReportingSniff.phpBefore:
(New file)
After:
Why: Employs precise AST token analysis to safely detect
error_reporting(),ini_set(),ini_alter(), anddefine()modifying runtime debugging configuration while completely avoiding false positives from string literals or comments.includes/Checker/Checks/General/Error_Reporting_Check.phpBefore:
(New file)
After:
Why: Exposes the new CodeAnalysis sniff as a high-priority notice/warning under the General and Plugin Repo categories.
includes/Checker/Default_Check_Repository.phpBefore:
After:
Why: Registers the new check within the default check repository.
Testing
Test 1: Run Unit Tests
npm run test-php -- --filter Error_Reporting_Check_TestsResult: Works as expected (2 tests, 7 assertions passed)