fix(EMBED-478): handle linked account lookup failures - #2539
Open
arch1995 wants to merge 1 commit into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
EMBED-478
Description
getUserInfoloads the authentication profile and linked accounts together.An error from the optional linked-account request currently rejects the full
user information request.
This change catches linked-account request errors, writes a warning, and
returns an empty linked-account list. The authentication profile remains
available to the caller.
Related backend change:
Web3Auth/citadel-server#91
How has this been tested?
npm run lint.npm run build.npm test.Screenshots (if appropriate)
Not applicable.
Types of changes
Checklist
Note
Low Risk
Narrow error-handling change in an optional data path; worst case is silently empty linked accounts when Citadel is down, which matches the intended degradation.
Overview
getLinkedAccountsnow wraps the Citadel/v1/userrequest in try/catch. On failure it logs a warning and returns[]instead of throwing.Because
getUserInfoloads the auth profile and linked accounts in parallel, this stops optional linked-account errors from rejecting the full user info call—the core auth profile still reaches callers, with no linked accounts until Citadel succeeds again.Reviewed by Cursor Bugbot for commit 7eaf774. Bugbot is set up for automated code reviews on this repo. Configure here.