Skip to content

sometimes scroll bar style not working - #2528

Merged
chaitanyapotti merged 1 commit into
masterfrom
fix/scroll-bar-style
Jul 22, 2026
Merged

sometimes scroll bar style not working#2528
chaitanyapotti merged 1 commit into
masterfrom
fix/scroll-bar-style

Conversation

@lionellbriones

@lionellbriones lionellbriones commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Jira Link

Description

Fixes the modal scrollbar styling that intermittently failed to apply. The scrollbar-color declaration was missing a track color and scrollbar-width, so browsers would fall back to the default scrollbar appearance in some cases.

How has this been tested?

Screenshots (if appropriate)

Before

scroll-style-before.mov

After

scroll-style-after.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Note

Low Risk
CSS-only presentation tweak in the modal package with no auth, data, or API impact.

Overview
Fixes intermittent default scrollbars in the Web3Auth modal by tightening Firefox-oriented scrollbar styling on .w3a-parent-container > *.

Those descendants now use scrollbar-width: thin and scrollbar-color: #e5e7eb transparent (thumb plus transparent track) instead of a thumb-only color. The duplicate scrollbar-color on .w3a--social-container is removed so styling is centralized on the parent rule.

Reviewed by Cursor Bugbot for commit d0e65b9. Bugbot is set up for automated code reviews on this repo. Configure here.

@lionellbriones
lionellbriones requested a review from a team as a code owner July 21, 2026 15:17
@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web3auth-web Ready Ready Preview, Comment Jul 21, 2026 3:17pm

Request Review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d0e65b9. Configure here.

}

.w3a--social-container {
scrollbar-color: #e5e7eb !important;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nested scrollbars lose styling

Medium Severity

The commit drops scrollbar-color (and does not add scrollbar-width) on .w3a--social-container, while scroll styling now lives only on .w3a-parent-container > *. The social login and wallet lists that use overflow-y-auto are nested descendants, not direct children, and scrollbar-color is not inherited, so those scrollbars can still fall back to the browser default.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d0e65b9. Configure here.

@chaitanyapotti
chaitanyapotti merged commit 03af537 into master Jul 22, 2026
7 checks passed
@chaitanyapotti
chaitanyapotti deleted the fix/scroll-bar-style branch July 22, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants