Skip to content

Update error message for other errors during account linking #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaitanyapotti merged 2 commits into from
Jun 2, 2026
Merged

Update error message for other errors during account linking #2510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc2d3bb
- show error codes for non AccountLinkingError type if available
lionellbriones Jun 2, 2026
657d6b8
fix error format test
lionellbriones Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/no-modal/src/account-linking/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,12 @@ export function formatAccountLinkingErrorMessage(error: unknown, fallbackMessage
return error.toString();
}

if (error instanceof Web3AuthError) {
return `[${error.code}] Account linking error: ${error.message || fallbackMessage}`;
}

if (error instanceof Error) {
return error.message || fallbackMessage;
return `Account linking error: ${error.message || fallbackMessage}`;
}

try {
Expand Down
2 changes: 1 addition & 1 deletion packages/no-modal/test/accountLinkingErrors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ describe("account-linking errors", () => {
});

it("formats regular errors using the error message", () => {
expect(formatAccountLinkingErrorMessage(new Error("Something failed"))).toBe("Something failed");
expect(formatAccountLinkingErrorMessage(new Error("Something failed"))).toBe("Account linking error: Something failed");
});

it("formats plain objects as json and uses the fallback for circular values", () => {
Expand Down