Skip to content

Viz for lidar pre processing base implementation - #31

Merged
brianzheng206 merged 8 commits into
mainfrom
viz_for_lidar_pre-processing-Jason
Jul 24, 2026
Merged

Viz for lidar pre processing base implementation#31
brianzheng206 merged 8 commits into
mainfrom
viz_for_lidar_pre-processing-Jason

Conversation

@jasonkdeng

@jasonkdeng jasonkdeng commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

📑 Description

Stitched viz.py into existing Open3D pipeline to reduce the brittleness of viz for lidar preprocessing. Currently may still require some fixes on the lidar preprocessing docker image, but no new bugs. Attached below is a video of the html interface for viz.

📹 (Optional) Video Demo of Changes

Recording.2026-07-09.183743.mp4

✅ Checklist

  • My code builds and runs locally without warnings
  • I added/updated tests if needed
  • I updated documentation / comments
  • I listed any breaking changes in the “Notes” section

📝 Notes for reviewers

./watod run ingest --bag /data/bags/<the bag>

./watod run lidar_preprocessing --bag NuScenes_v1_0_mini_scene_0655 --chunk 0000 --force --no-auto-reduce

./watod run lidar_preprocessing viz \
  --bag NuScenes_v1_0_mini_scene_0655 \
  --chunk 0000 \
  --backend html \
  --open

@brianzheng206 brianzheng206 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff, couple of small things

Comment thread src/lidar_preprocessing/README.md Outdated

```bash
wato_lidar_preprocessing viz --bag <bag_id> --chunk <chunk_id>
wato_lidar_preprocessing viz --bag <bag_id> --chunk <chunk_id> --backend html

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of this is kinda slop, I also think if the html backend is able to provide us everything we need we can ditch open3d, and have that as default.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's really fair. I moved open3d to just be a fallback and added the point classification to html directly

Comment thread docker/template.Dockerfile Outdated
ARG USER_UID=1000
ARG USER_GID=1000
ARG CLAUDE_CODE=false
ARG DEV_PYTEST_SPEC=pytest

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why we are changing this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowkey added to make sure that the project pytest dependency is always aligned, but you're right. The previous written in hardcode is stable and will be good. I'll fix that

done

# shellcheck disable=SC2206
COMPOSE_FILES=(${COMPOSE_FILES_STR})

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally dont change this file, would you be able to define everything with cli.py? If we settle on one viz I think we wont even need this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ye

@brianzheng206

Copy link
Copy Markdown
Collaborator

not sure if we documented anywhere either but run pre-commit run --all-files to pass the precommit check

@jasonkdeng

Copy link
Copy Markdown
Contributor Author

not sure if we documented anywhere either but run pre-commit run --all-files to pass the precommit check

it's documented in the readme

@brianzheng206
brianzheng206 merged commit 7a5da2b into main Jul 24, 2026
4 of 5 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in wato_world Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants