feat(ui): non full-windowed support#55
Open
bertrand-caron wants to merge 1 commit intoVincentCATILLON:masterfrom
Open
feat(ui): non full-windowed support#55bertrand-caron wants to merge 1 commit intoVincentCATILLON:masterfrom
bertrand-caron wants to merge 1 commit intoVincentCATILLON:masterfrom
Conversation
* Useful if using a navbar, or any other component that obscurs part of the screen.
Author
|
@VincentCATILLON Bumping in case you have not seen this yet and are interested :) |
Author
|
@VincentCATILLON Are you still maintaining this repository, or is there a better place to merge this? |
Owner
|
Sorry @bertrand-caron about the delay, I'll make a review asap |
| |------------------|---------------------------------|--------------------------------------------|----------|--------------------------| | ||
| | count | number | items count to display | required | | | ||
| | origin | {x: number, y: number} | animation position origin | required | | | ||
| | window | {width: number, height: number} | width and height of the animation "window" | | Dimensions.get('window') | |
Owner
There was a problem hiding this comment.
Suggested change
| | window | {width: number, height: number} | width and height of the animation "window" | | Dimensions.get('window') | | |
| | dimensions | {width: number, height: number} | width and height of the animation "window" | | Dimensions.get('window') | |
looks more explicit than window
| x: number; | ||
| y: number | ||
| }; | ||
| window?: { |
Owner
There was a problem hiding this comment.
Suggested change
| window?: { | |
| dimensions?: { |
| x: number, | ||
| y: number | ||
| }, | ||
| window?: { |
Owner
There was a problem hiding this comment.
Suggested change
| window?: { | |
| dimensions?: { |
|
|
||
| render() { | ||
| const { origin, fadeOut } = this.props; | ||
| const { origin, fadeOut, window } = this.props; |
Owner
There was a problem hiding this comment.
Suggested change
| const { origin, fadeOut, window } = this.props; | |
| const { origin, fadeOut, dimensions = Dimensions.get('window') } = this.props; |
| const { origin, fadeOut, window } = this.props; | ||
| const { items } = this.state; | ||
| const { height, width } = Dimensions.get('window'); | ||
| const { height, width } = window ?? Dimensions.get('window'); |
Owner
There was a problem hiding this comment.
Suggested change
| const { height, width } = window ?? Dimensions.get('window'); | |
| const { height, width } = dimensions; |
Owner
|
Thanks for your nice contribution I think the prop should be more explicit ( |
VincentCATILLON
changed the title
|
Can this get merged @VincentCATILLON would be helpful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for non-fullscreen confetti. Useful if using a navbar, or any other component that obscures part of the screen. behaviour is backwards compatible (defaults to
Dimensions.get('window')).Result
N/A
Related issues
N/A