Skip to content

[Core] [FMOD] Neutral panning when source is close to listener #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Schroedingers-Cat wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Core] [FMOD] Neutral panning when source is close to listener #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21ed00e
[core] avoid panning fully left when source and listener are close
Schroedingers-Cat Apr 21, 2026
95ad6d4
[fmod] nudge source origin slightly to the front when on listener pos…
Schroedingers-Cat Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions core/src/core/api_geometry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ IPLVector3 CContext::calculateRelativeDirection(IPLVector3 sourcePosition,
auto _listenerRight = Vector3f::unitVector(Vector3f::cross(_listenerAhead, _listenerUp));

auto listenerToSource = _sourcePosition - _listenerPosition;
auto _relativeDirection = Vector3f::kYAxis;
auto _relativeDirection = Vector3f(0.f, 0.f, -1.f);

if (listenerToSource.length() > 1e-5f)
{
Expand All @@ -52,8 +52,7 @@ IPLVector3 CContext::calculateRelativeDirection(IPLVector3 sourcePosition,
_relativeDirection.z() = (-Vector3f::dot(listenerToSource, _listenerAhead));
}

IPLVector3 relativeDirection = {_relativeDirection.x(), _relativeDirection.y(), _relativeDirection.z()};
return relativeDirection;
return {_relativeDirection.x(), _relativeDirection.y(), _relativeDirection.z()};
}

}
6 changes: 6 additions & 0 deletions fmod/src/spatialize_effect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,6 +1032,12 @@ FMOD_RESULT F_CALL process(FMOD_DSP_STATE* state,

auto sourceCoordinates = calcCoordinates(effect->source.absolute);
auto listenerCoordinates = calcListenerCoordinates(state);
if (sourceCoordinates.origin.x == listenerCoordinates.origin.x &&
sourceCoordinates.origin.y == listenerCoordinates.origin.y &&
sourceCoordinates.origin.z == listenerCoordinates.origin.z)
{
sourceCoordinates.origin.z -= 1e-4f;
}

if (operation == FMOD_DSP_PROCESS_QUERY)
{
Expand Down