fix(email-core): enforce reply allowlist for reply-all recipients#62
Merged
stevenobiajulu merged 1 commit intomainfrom Apr 28, 2026
Merged
fix(email-core): enforce reply allowlist for reply-all recipients#62stevenobiajulu merged 1 commit intomainfrom
stevenobiajulu merged 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This closes the reply allowlist gap in
reply_to_emailwhenreply_allis enabled.ccaddresses in the allowlist gateRoot Cause
reply_to_emailonly checkedoriginalMessage.from.emailbefore calling the provider send path. Whenreply_allwas left at its defaulttrue, provider reply expansion could still add non-allowlisted thread recipients, which bypassed the send allowlist.Impact
Outbound replies now fail before send if any effective reply recipient falls outside the send allowlist, which brings the action behavior back in line with the documented security model.
Fixes #57.
Validation
npm run test:run -w @usejunior/email-core -- src/actions/reply.test.tsnpm run lint -w @usejunior/email-core