Fix RoboLowess default temporal_resolution handling (#137)#138
Open
oindabi wants to merge 8 commits intoUSRA-STI:mainfrom
Open
Fix RoboLowess default temporal_resolution handling (#137)#138oindabi wants to merge 8 commits intoUSRA-STI:mainfrom
oindabi wants to merge 8 commits intoUSRA-STI:mainfrom
Conversation
Signed-off-by: oindabi <omukherjee@usra.edu>
AdamGoldstein-USRA
approved these changes
Apr 6, 2026
Collaborator
AdamGoldstein-USRA
left a comment
There was a problem hiding this comment.
This looks good to me. Asked Josh to review to ensure it takes care of his issue.
Contributor
|
This fix avoids the crash, but it seems like setting a default Is there a specific reason to define temporal resolution from the binning? I don't see any changes to unit tests. We should add or update one of the tests to use the default settings so that issues like this are caught in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a TypeError in RoboLowess.fit() when using default settings and
temporal_resolution=None. The code now falls back to a valid positivetime resolution when
win_sizeis auto-computed.