Skip to content

Fix RoboLowess default temporal_resolution handling (#137)#138

Open
oindabi wants to merge 8 commits intoUSRA-STI:mainfrom
oindabi:issue-137
Open

Fix RoboLowess default temporal_resolution handling (#137)#138
oindabi wants to merge 8 commits intoUSRA-STI:mainfrom
oindabi:issue-137

Conversation

@oindabi
Copy link
Copy Markdown
Contributor

@oindabi oindabi commented Apr 6, 2026

Fixes a TypeError in RoboLowess.fit() when using default settings and
temporal_resolution=None. The code now falls back to a valid positive
time resolution when win_size is auto-computed.

Copy link
Copy Markdown
Collaborator

@AdamGoldstein-USRA AdamGoldstein-USRA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Asked Josh to review to ensure it takes care of his issue.

@joshuarwood
Copy link
Copy Markdown
Contributor

This fix avoids the crash, but it seems like setting a default temporal_resolution=1.0 would be easier to maintain than the nested if/else statements.

Is there a specific reason to define temporal resolution from the binning?

I don't see any changes to unit tests. We should add or update one of the tests to use the default settings so that issues like this are caught in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants