feat(NO-JIRA): add pnpm support to shared frontend workflows by bobobowis · Pull Request #250 · Typeform/.github

bobobowis · 2026-07-07T13:03:09Z

Overview

Jira: NOJIRA-1

Extends shared reusable frontend workflows and setup-node-with-cache to support pnpm-based repos alongside existing Yarn consumers. First consumer: admin-home.

All changes are additive — Yarn behavior is untouched. Repos opt in via package-manager: pnpm. pnpm callers pass all commands explicitly (no dynamic defaults).

Changes

Add package-manager input (yarn|pnpm, default: yarn) to setup-node-with-cache, frontend-pr-workflow, frontend-deploy-workflow, sonarcloud-scan, and the three run-cypress-*/run-playwright-visual shared-actions
Install pnpm via pnpm/action-setup@v4 (skipped when asdf manages it)
Branch all PM-specific logic: cache paths, cache key (pnpm-lock.yaml), integrity check (.modules.yaml vs .yarn-integrity), install command (pnpm install --frozen-lockfile), and postinstall step
pnpm cache key prefix pnpm- isolates from yarn caches — no cross-PM cache pollution
Fix asdf reshim: asdf reshim pnpm when package-manager: pnpm, asdf reshim yarn otherwise
Clarify cache-mode input description to "package manager cache" across all files
Update README and CACHE-STRATEGY-GUIDE with pnpm cache mode docs

Backward compatibility

Zero changes required from existing Yarn callers — all new inputs default to yarn.

How to use (pnpm repo)

uses: Typeform/.github/.github/workflows/frontend-pr-workflow.yml@v1
with:
  package-manager: 'pnpm'
  cache-mode: 'node_modules-only'   # or 'full' for pnpm workspaces
  build-command: 'pnpm run dist:preview'
  clean-command: 'pnpm run clean'
  deploy-command: 'pnpm run deploy:preview'
  # ... all other commands passed explicitly

bobobowis · 2026-07-09T13:28:16Z


      - name: Setup Node with Cache
-        uses: Typeform/.github/shared-actions/setup-node-with-cache@v1
+        uses: Typeform/.github/shared-actions/setup-node-with-cache@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis · 2026-07-09T13:28:30Z


      - name: Setup Node with Cache
-        uses: Typeform/.github/shared-actions/setup-node-with-cache@v1
+        uses: Typeform/.github/shared-actions/setup-node-with-cache@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis · 2026-07-09T13:28:40Z


      - name: Setup Node with Cache
-        uses: Typeform/.github/shared-actions/setup-node-with-cache@v1
+        uses: Typeform/.github/shared-actions/setup-node-with-cache@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis · 2026-07-09T13:28:57Z

    steps:
      - name: Run Cypress Functional Tests
-        uses: Typeform/.github/shared-actions/run-cypress-functional@v1
+        uses: Typeform/.github/shared-actions/run-cypress-functional@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis · 2026-07-09T13:29:02Z

    steps:
      - name: Run Cypress Visual Tests
-        uses: Typeform/.github/shared-actions/run-cypress-visual@v1
+        uses: Typeform/.github/shared-actions/run-cypress-visual@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis · 2026-07-09T13:30:06Z


      - name: Setup Node with Cache
-        uses: Typeform/.github/shared-actions/setup-node-with-cache@v1
+        uses: Typeform/.github/shared-actions/setup-node-with-cache@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis · 2026-07-09T13:30:23Z

    steps:
      - name: Run Cypress Functional Tests
-        uses: Typeform/.github/shared-actions/run-cypress-functional@v1
+        uses: Typeform/.github/shared-actions/run-cypress-functional@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis · 2026-07-09T13:30:28Z

    steps:
      - name: Run Playwright Visual Tests
-        uses: Typeform/.github/shared-actions/run-playwright-visual@v1
+        uses: Typeform/.github/shared-actions/run-playwright-visual@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis · 2026-07-09T13:30:33Z

    steps:
      - name: Run Cypress Visual Tests
-        uses: Typeform/.github/shared-actions/run-cypress-visual@v1
+        uses: Typeform/.github/shared-actions/run-cypress-visual@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis · 2026-07-09T13:30:41Z


      - name: Setup Node with Cache
-        uses: Typeform/.github/shared-actions/setup-node-with-cache@v1
+        uses: Typeform/.github/shared-actions/setup-node-with-cache@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis · 2026-07-09T13:29:13Z

    permissions:
      contents: read
-    uses: Typeform/.github/.github/workflows/sonarcloud-scan.yml@v1
+    uses: Typeform/.github/.github/workflows/sonarcloud-scan.yml@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis · 2026-07-09T13:30:16Z

    permissions:
      contents: read
-    uses: Typeform/.github/.github/workflows/sonarcloud-scan.yml@v1
+    uses: Typeform/.github/.github/workflows/sonarcloud-scan.yml@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

sonarqubecloud · 2026-07-09T12:14:57Z

Quality Gate passed

Issues
27 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bobobowis · 2026-07-09T13:28:24Z


      - name: Setup Jarvis
-        uses: Typeform/.github/shared-actions/setup-jarvis@v1
+        uses: Typeform/.github/shared-actions/setup-jarvis@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis · 2026-07-09T13:28:37Z


      - name: Setup Jarvis
-        uses: Typeform/.github/shared-actions/setup-jarvis@v1
+        uses: Typeform/.github/shared-actions/setup-jarvis@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis · 2026-07-09T13:28:50Z

      - name: Setup Playwright
        if: inputs.integration-test-framework == 'playwright'
-        uses: Typeform/.github/shared-actions/setup-playwright@v1
+        uses: Typeform/.github/shared-actions/setup-playwright@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis · 2026-07-09T13:29:26Z


      - name: Setup Jarvis
-        uses: Typeform/.github/shared-actions/setup-jarvis@v1
+        uses: Typeform/.github/shared-actions/setup-jarvis@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis · 2026-07-09T13:29:40Z


      - name: Setup Jarvis
-        uses: Typeform/.github/shared-actions/setup-jarvis@v1
+        uses: Typeform/.github/shared-actions/setup-jarvis@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis · 2026-07-09T13:29:49Z


      - name: Setup Jarvis
-        uses: Typeform/.github/shared-actions/setup-jarvis@v1
+        uses: Typeform/.github/shared-actions/setup-jarvis@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis · 2026-07-09T13:29:59Z


      - name: Setup Jarvis
-        uses: Typeform/.github/shared-actions/setup-jarvis@v1
+        uses: Typeform/.github/shared-actions/setup-jarvis@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis · 2026-07-09T13:30:02Z

      - name: Setup Playwright
        if: inputs.integration-test-framework == 'playwright'
-        uses: Typeform/.github/shared-actions/setup-playwright@v1
+        uses: Typeform/.github/shared-actions/setup-playwright@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis · 2026-07-09T13:30:11Z


      - name: Setup Jarvis
-        uses: Typeform/.github/shared-actions/setup-jarvis@v1
+        uses: Typeform/.github/shared-actions/setup-jarvis@feat/pnpm-support-shared-frontend-workflows


This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

bobobowis force-pushed the feat/pnpm-support-shared-frontend-workflows branch 2 times, most recently from a6130a9 to 88da721 Compare July 7, 2026 14:39

github-advanced-security AI found potential problems Jul 7, 2026

View reviewed changes

Comment thread .github/workflows/frontend-pr-workflow.yml Fixed

bobobowis force-pushed the feat/pnpm-support-shared-frontend-workflows branch from 88da721 to 9bb7563 Compare July 7, 2026 14:46

github-advanced-security AI found potential problems Jul 7, 2026

View reviewed changes

bobobowis force-pushed the feat/pnpm-support-shared-frontend-workflows branch 4 times, most recently from 5165e31 to 4cfcec5 Compare July 8, 2026 12:21

github-advanced-security AI found potential problems Jul 8, 2026

View reviewed changes

Comment thread .github/workflows/frontend-deploy-workflow.yml Fixed

Comment thread .github/workflows/frontend-pr-workflow.yml Fixed

bobobowis force-pushed the feat/pnpm-support-shared-frontend-workflows branch 2 times, most recently from 3e44a81 to 8ea430b Compare July 8, 2026 13:56

github-advanced-security AI found potential problems Jul 8, 2026

View reviewed changes

Comment thread .github/workflows/frontend-deploy-workflow.yml Fixed

Comment thread .github/workflows/frontend-pr-workflow.yml Fixed

bobobowis force-pushed the feat/pnpm-support-shared-frontend-workflows branch 4 times, most recently from 4f28212 to e7eac0d Compare July 8, 2026 14:52

github-advanced-security AI found potential problems Jul 8, 2026

View reviewed changes

bobobowis force-pushed the feat/pnpm-support-shared-frontend-workflows branch from e7eac0d to e4c0b43 Compare July 8, 2026 15:41

github-advanced-security AI found potential problems Jul 8, 2026

View reviewed changes

bobobowis force-pushed the feat/pnpm-support-shared-frontend-workflows branch from e4c0b43 to ff9b7a8 Compare July 8, 2026 15:52

bobobowis added 2 commits July 9, 2026 14:14

feat(TU-41409): Add pnpm support to shared frontend workflows

814088b

feat(TU-4409): Add sha to internal workflows

3c7315b

bobobowis force-pushed the feat/pnpm-support-shared-frontend-workflows branch from ff9b7a8 to 3c7315b Compare July 9, 2026 12:14

github-advanced-security AI found potential problems Jul 9, 2026

View reviewed changes

bobobowis marked this pull request as ready for review July 9, 2026 13:17

bobobowis requested a review from a team as a code owner July 9, 2026 13:17

Uh oh!

Conversation

bobobowis commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Changes

Backward compatibility

How to use (pnpm repo)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jul 9, 2026

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bobobowis commented Jul 7, 2026 •

edited

Loading