Skip to content

Added share button#1046

Open
minimaluminium wants to merge 1 commit intomainfrom
add-share-button
Open

Added share button#1046
minimaluminium wants to merge 1 commit intomainfrom
add-share-button

Conversation

@minimaluminium
Copy link
Copy Markdown
Member

ref https://linear.app/ghost/issue/FEA-613/update-themes-to-include-share-button

We're introducing native share button feature in Portal and this adds share button support to official themes.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 437e7d9d-8460-4f0b-bad1-368e611a7c1f

📥 Commits

Reviewing files that changed from the base of the PR and between 0bb2ef6 and aa652b4.

⛔ Files ignored due to path filters (1)
  • assets/built/screen.css.map is excluded by !**/*.map
📒 Files selected for processing (3)
  • assets/built/screen.css
  • assets/css/screen.css
  • post.hbs

Walkthrough

This pull request introduces share button functionality through CSS styling updates and a template modification. The changes add a new .gh-button-share CSS class with base styles and theme-specific overrides for both dark mode and auto-color schemes. The .article-byline flex layout is updated with align-items: center and gap: 16px for improved spacing. Additionally, the sans-serif font stack is expanded with Fira Sans and Droid Sans entries. A share button link is inserted into the post template after the byline section.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Added share button' directly and concisely describes the main change: introducing a new share button feature to the theme.
Description check ✅ Passed The description is directly related to the changeset, explaining that share button support is being added to official themes in alignment with Portal's native share button feature.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-share-button

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant