Skip to content

update particle grass#952

Open
Xtarsia wants to merge 6 commits intoTokisanGames:mainfrom
Xtarsia:minor-update-to-particle-grass
Open

update particle grass#952
Xtarsia wants to merge 6 commits intoTokisanGames:mainfrom
Xtarsia:minor-update-to-particle-grass

Conversation

@Xtarsia
Copy link
Copy Markdown
Collaborator

@Xtarsia Xtarsia commented Mar 8, 2026

Updates particle grass to match ground level region blending when background mode is flat or noise.

@TokisanGames
Copy link
Copy Markdown
Owner

Great that it respects the region blend. However it continues outside of the region boundary which is only good for Flat and odd for None/Noise.

@TokisanGames
Copy link
Copy Markdown
Owner

Adjusted the texture filter to be a uniform with a positive selection rather than negative filter.

shader_parameter/condition_dither_range = 0.15
shader_parameter/surface_slope_min = 0.87
shader_parameter/distance_fade_ammount = 0.66
shader_parameter/ground_level = -618.9519819002201
Copy link
Copy Markdown
Owner

@TokisanGames TokisanGames Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this and region_blend get updated and saved in this file?

I changed ground level in the terrain, saved, and restarted it didn't change in the particle material or file.
Because you're updating with the render server instead of the material, the changes don't get pushed or updated in the inspector, or apparently saved in the file.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be synced by _update_process_parameters() interrain_3D_particles.gd

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That probably updates it in the renderer, but not in the resource in the inspector or the file from what I've seen. So I don't know how you got it into the file so it could be pushed in this PR. I couldn't get it to update on mine. And if someone looks in the private folder the settings will appear wrong.

@TokisanGames
Copy link
Copy Markdown
Owner

TokisanGames commented Mar 8, 2026

Are these unnecessary?

// Defined Constants
#define SKIP_PASS 0
#define VERTEX_PASS 1
#define FRAGMENT_PASS 2


The items in the gdscript info group and shadow mode should be moved up above the process & particle material. The last items should be:

  • process material
  • mesh
  • mesh material

I see info is read only, fine, it can go at the very top and marked read only like Terrain3D version so it greys out. Though setting distance by meters is much more intuitive than instance_spacing * cell_width*grid_width or whatever.
Maybe renaming min_draw_distance is in order. It looks more like max draw distance. But if it's read only, maybe calculated_distance or draw distance or calculated_radius.

@pl4ttenbau
Copy link
Copy Markdown

how does it look, any progress towards merge?

@TokisanGames
Copy link
Copy Markdown
Owner

All updates will be listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants