feat: render DisplayName in Icons for better DX#326
Conversation
|
Warning Rate limit exceeded@joacotornello has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 32 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA changelog entry was added for version 1.12.0 of the icons package, documenting a new feature. In the component template, the React component's Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Getting startedPlease make sure you read our documentation on how to write code for components, stories and styles.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting
⛔ Files ignored due to path filters (1)
.yarn/versions/57efeb47.ymlis excluded by!**/.yarn/**
📒 Files selected for processing (2)
packages/icons/CHANGELOG.md(1 hunks)packages/icons/templates/components.js(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/CHANGELOG.md
⚙️ CodeRabbit Configuration File
Ensure CHANGELOG.md updates follow the established format: YYYY-MM-DD version with categorized entries (Breaking changes, New features, Bug fixes, Others). Each entry must include PR reference and author, and changes must be properly versioned (major/minor/patch). Changes MUST be documented in their respective package's CHANGELOG.md.
Files:
packages/icons/CHANGELOG.md
🪛 markdownlint-cli2 (0.17.2)
packages/icons/CHANGELOG.md
7-7: Heading levels should only increment by one level at a time
Expected: h3; Actual: h4
(MD001, heading-increment)
🔇 Additional comments (1)
packages/icons/templates/components.js (1)
23-24: displayName assignment LGTMExplicitly setting
Component.displayNameright after definition is the canonical pattern for clearer React DevTools output. No issues spotted.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting
⛔ Files ignored due to path filters (1)
.yarn/versions/57efeb47.ymlis excluded by!**/.yarn/**
📒 Files selected for processing (1)
packages/icons/CHANGELOG.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/CHANGELOG.md
⚙️ CodeRabbit Configuration File
Ensure CHANGELOG.md updates follow the established format: YYYY-MM-DD version with categorized entries (Breaking changes, New features, Bug fixes, Others). Each entry must include PR reference and author, and changes must be properly versioned (major/minor/patch). Changes MUST be documented in their respective package's CHANGELOG.md.
Files:
packages/icons/CHANGELOG.md
🪛 markdownlint-cli2 (0.17.2)
packages/icons/CHANGELOG.md
7-7: Heading levels should only increment by one level at a time
Expected: h3; Actual: h4
(MD001, heading-increment)
9-9: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
⏰ Context from checks skipped due to timeout of 30000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Analyze SonarCloud
- GitHub Check: pipeline-quality
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #326 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 351 351
Lines 2597 2597
Branches 430 430
=======================================
Hits 2580 2580
Misses 15 15
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🚀✨ Your Storybook preview is ready! Happy reviewing! 🎉 |
|
3 participants
Type
Screenshots
Before:
(notice the Anonymous showing up instead of the Icon component name)
After:
Summary by CodeRabbit